content/browser/web_contents/web_contents_impl_browsertest.cc - Issue 2396493002: Improve the TestNavigationManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_browsertest.cc

Issue 2396493002: Improve the TestNavigationManager (Closed)

Patch Set: Addressed Nasko's nit Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl_browsertest.cc

diff --git a/content/browser/web_contents/web_contents_impl_browsertest.cc b/content/browser/web_contents/web_contents_impl_browsertest.cc

index 21113083f7e9a29aaf74aa79d0f5135efb96f42c..e20d1b45d8b4d83b0360ccc50d4b35002424e8cc 100644

--- a/content/browser/web_contents/web_contents_impl_browsertest.cc

+++ b/content/browser/web_contents/web_contents_impl_browsertest.cc

@@ -923,7 +923,7 @@ IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest,

TestNavigationManager cross_site_delayer(shell()->web_contents(),

kCrossSiteURL);

shell()->LoadURL(kCrossSiteURL);

- EXPECT_TRUE(cross_site_delayer.WaitForWillStartRequest());

+ EXPECT_TRUE(cross_site_delayer.WaitForRequestStart());

// Click on a link in the page. This will show the BeforeUnload dialog.

// Ensure the dialog is not dismissed, which will cause it to still be