Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2396413002: VideoCaptureImpl: check that there's still a channel in ~VideoCaptureImpl() before sending (Closed)

Created:
4 years, 2 months ago by mcasas
Modified:
4 years, 2 months ago
Reviewers:
emircan
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoCaptureImpl: check that there's still a channel in ~VideoCaptureImpl() before sending This was not hit when using IPC due to the channel ignoring the late message, but now we need to protect against a disappeared VideoCaptureHost explicitly. Also, this CL the unused |suspended_| variable and simplified RemoveClient() method -- I know, I know, I shouldn't bundle modifications in a CL... but these were just too easy to let them pass. BUG=653806, 651897 Committed: https://crrev.com/f81183123c82618825cd5734c5ace89fe1723d3c Cr-Commit-Position: refs/heads/master@{#423907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M content/renderer/media/video_capture_impl.h View 3 chunks +3 lines, -5 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 5 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mcasas
emircan@ PTAL (easy CL)
4 years, 2 months ago (2016-10-07 16:33:23 UTC) #3
emircan
lgtm
4 years, 2 months ago (2016-10-07 17:09:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396413002/1
4 years, 2 months ago (2016-10-07 17:13:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 17:59:39 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 18:01:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f81183123c82618825cd5734c5ace89fe1723d3c
Cr-Commit-Position: refs/heads/master@{#423907}

Powered by Google App Engine
This is Rietveld 408576698