Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: content/renderer/media/video_capture_impl.h

Issue 2396413002: VideoCaptureImpl: check that there's still a channel in ~VideoCaptureImpl() before sending (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/video_capture_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/video_capture_impl.h
diff --git a/content/renderer/media/video_capture_impl.h b/content/renderer/media/video_capture_impl.h
index d626dbec2749b09b48a4bdd20b5b87c1088de85b..28d747739ed6d04b7e36bd65fcd7d7abbb176040 100644
--- a/content/renderer/media/video_capture_impl.h
+++ b/content/renderer/media/video_capture_impl.h
@@ -47,12 +47,11 @@ namespace content {
class CONTENT_EXPORT VideoCaptureImpl
: public VideoCaptureMessageFilter::Delegate {
public:
- ~VideoCaptureImpl() override;
-
VideoCaptureImpl(
media::VideoCaptureSessionId session_id,
VideoCaptureMessageFilter* filter,
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner);
+ ~VideoCaptureImpl() override;
// Stop/resume delivering video frames to clients, based on flag |suspend|.
void SuspendCapture(bool suspend);
@@ -154,7 +153,7 @@ class CONTENT_EXPORT VideoCaptureImpl
void RestartCapture();
void StartCaptureInternal();
- // Helpers.
+ // Tries to remove |client_id| from |clients|, returning false if not found.
bool RemoveClient(int client_id, ClientInfoMap* clients);
mojom::VideoCaptureHost* GetVideoCaptureHost();
@@ -196,11 +195,10 @@ class CONTENT_EXPORT VideoCaptureImpl
// client to this class via StartCapture().
media::VideoCaptureParams params_;
- // The device's first captured frame referecne time sent from browser process
+ // The device's first captured frame reference time sent from browser process
// side.
base::TimeTicks first_frame_ref_time_;
- bool suspended_;
VideoCaptureState state_;
// IO message loop reference for checking correct class operation.
« no previous file with comments | « no previous file | content/renderer/media/video_capture_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698