Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: src/builtins/builtins-dataview.cc

Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-conversion.cc ('k') | src/builtins/builtins-function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-dataview.cc
diff --git a/src/builtins/builtins-dataview.cc b/src/builtins/builtins-dataview.cc
index 7eb7f534a42ac4e16c7ec495fb100a313d1c8744..3d14e31d3a3ba377f47eb2dc2b46e66461169849 100644
--- a/src/builtins/builtins-dataview.cc
+++ b/src/builtins/builtins-dataview.cc
@@ -88,7 +88,7 @@ BUILTIN(DataViewConstructor_ConstructStub) {
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result,
JSObject::New(target, new_target));
for (int i = 0; i < ArrayBufferView::kInternalFieldCount; ++i) {
- Handle<JSDataView>::cast(result)->SetInternalField(i, Smi::kZero);
+ Handle<JSDataView>::cast(result)->SetInternalField(i, Smi::FromInt(0));
}
// 12. Set O's [[ViewedArrayBuffer]] internal slot to buffer.
« no previous file with comments | « src/builtins/builtins-conversion.cc ('k') | src/builtins/builtins-function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698