src/builtins/builtins-array.cc - Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-array.cc

Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-array.cc

diff --git a/src/builtins/builtins-array.cc b/src/builtins/builtins-array.cc

index 0795b92ac80f5ceb609924bdd74b39e89fd3a6a3..b4969f1e575b2003f6b94a9c353011bfa0f8dfe0 100644

--- a/src/builtins/builtins-array.cc

+++ b/src/builtins/builtins-array.cc

@@ -1084,7 +1084,7 @@ Object* Slow_ArrayConcat(BuiltinArguments* args, Handle<Object> species,

storage = SeededNumberDictionary::New(isolate, at_least_space_for);

} else {

DCHECK(species->IsConstructor());

- Handle<Object> length(Smi::kZero, isolate);

+ Handle<Object> length(Smi::FromInt(0), isolate);

Handle<Object> storage_object;

ASSIGN_RETURN_FAILURE_ON_EXCEPTION(

isolate, storage_object,

« no previous file with comments | « src/builtins/arm64/builtins-arm64.cc ('k') | src/builtins/builtins-conversion.cc » ('j') | no next file with comments »