Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 239633002: Revert 263828 "Do not reserve an access point code for CHROME_IO..." (Closed)

Created:
6 years, 8 months ago by hshi1
Modified:
6 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 263828 "Do not reserve an access point code for CHROME_IO..." > Do not reserve an access point code for CHROME_IOS_RESERVED > > Access point values need to be coordinated with the team using them. Since > CHROME_IOS_RESERVED is not used, do not reserve an access point for that > enum, and instead assert if it is ever used. > > BUG=360686 > > Review URL: https://codereview.chromium.org/237273002 TBR=sdefresne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M trunk/src/rlz/lib/lib_values.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hshi1
6 years, 8 months ago (2014-04-15 18:50:41 UTC) #1
hshi1
6 years, 8 months ago (2014-04-15 18:50:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r263952.

Powered by Google App Engine
This is Rietveld 408576698