Do not reserve an access point code for CHROME_IOS_RESERVED

Do not reserve an access point code for CHROME_IOS_RESERVED

Access point values need to be coordinated with the team using them. Since
CHROME_IOS_RESERVED is not used, do not reserve an access point for that
enum, and instead assert if it is ever used.

BUG=360686
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263828

[sdefresne, 2014-04-14 17:13:01]

Please have a look.

[sdefresne, 2014-04-14 17:26:10]

+ kareng for cherry-picking to M35

[Roger Tawa OOO till Jul 10th, 2014-04-14 19:35:19]

lgtm

https://codereview.chromium.org/237273002/diff/1/rlz/lib/lib_values.cc
File rlz/lib/lib_values.cc (right):

https://codereview.chromium.org/237273002/diff/1/rlz/lib/lib_values.cc#newcod...
rlz/lib/lib_values.cc:104: case CHROME_IOS_RESERVED:           break;
Or just remove lines 102-104 completely so that it falls through?

[pkl (ping after 24h if needed), 2014-04-14 19:43:09]

https://codereview.chromium.org/237273002/diff/1/rlz/lib/lib_values.cc
File rlz/lib/lib_values.cc (right):

https://codereview.chromium.org/237273002/diff/1/rlz/lib/lib_values.cc#newcod...
rlz/lib/lib_values.cc:104: case CHROME_IOS_RESERVED:           break;
On 2014/04/14 19:35:20, Roger Tawa wrote:
> Or just remove lines 102-104 completely so that it falls through?

Compiler will fail because not all enum values are listed and there's no
"default".

[sdefresne, 2014-04-14 21:46:21]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-04-14 21:47:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sdefresne@chromium.org/237273002/1

[commit-bot: I haz the power, 2014-04-14 22:59:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-14 22:59:23]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[sdefresne, 2014-04-15 06:15:38]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-04-15 06:16:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sdefresne@chromium.org/237273002/1

[commit-bot: I haz the power, 2014-04-15 13:08:36]

Change committed as 263828