third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h - Issue 2396293002: Remove WaitUntilObserver::decrementPendingActivity() from RespondWithObserver::contextDestroyed()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h

Issue 2396293002: Remove WaitUntilObserver::decrementPendingActivity() from RespondWithObserver::contextDestroyed() (Closed)

Patch Set: add note Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h b/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h

index e35180f3be62091e3eb5db9e8ec8f71a43671a3a..03d806ca926ca46c675939ae6de4eec3dee427b8 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h

@@ -50,6 +50,8 @@ class MODULES_EXPORT WaitUntilObserver final

// These methods can be called when the lifecycle of ExtendableEvent

// observed by this WaitUntilObserver should be extended by other reason

// than ExtendableEvent.waitUntil.

+ // Note: There is no need to call decrementPendingActivity() after the context

+ // is being destroyed.

void incrementPendingActivity();

void decrementPendingActivity();

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp ('k') | no next file » | no next file with comments »