third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp - Issue 2396293002: Remove WaitUntilObserver::decrementPendingActivity() from RespondWithObserver::contextDestroyed()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 2396293002: Remove WaitUntilObserver::decrementPendingActivity() from RespondWithObserver::contextDestroyed() (Closed)

Patch Set: add note Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

index bb450a438e72e691cc21dd08e9988a7399303259..3c587c6f910550c0d5c55f004d68573a32ff237b 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

@@ -188,7 +188,6 @@ void RespondWithObserver::contextDestroyed() {

ContextLifecycleObserver::contextDestroyed();

if (m_observer) {

DCHECK_EQ(Pending, m_state);

- m_observer->decrementPendingActivity();

m_observer.clear();

}

m_state = Done;

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h » ('j') | no next file with comments »