Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5794)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

Issue 2396133003: Change the logic how Subesource Filter propagates activation. (Closed)
Patch Set: fix test, for real now Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
index 7f03120c7117e491e86af228ddd6861b7ce7eb27..26aec307d46ebef81a79c0871894812ae4ac9874 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
@@ -929,6 +929,8 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest,
EXPECT_EQ(0U, driver_factory->activation_set().size());
chrome::NavigateParams params(browser(), bad_url, ui::PAGE_TRANSITION_LINK);
ui_test_utils::NavigateToURL(&params);
+ driver_factory->ReadyToCommitMainFrameNavigation(web_contents->GetMainFrame(),
+ bad_url);
EXPECT_EQ(1U, driver_factory->activation_set().size());
EXPECT_TRUE(got_hit_report());
@@ -954,6 +956,8 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, SocEngReportingBlacklistEmpty) {
EXPECT_EQ(0U, driver_factory->activation_set().size());
chrome::NavigateParams params(browser(), bad_url, ui::PAGE_TRANSITION_LINK);
ui_test_utils::NavigateToURL(&params);
+ driver_factory->ReadyToCommitMainFrameNavigation(web_contents->GetMainFrame(),
+ bad_url);
EXPECT_EQ(0U, driver_factory->activation_set().size());
EXPECT_TRUE(got_hit_report());

Powered by Google App Engine
This is Rietveld 408576698