Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Side by Side Diff: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

Issue 2396133003: Change the logic how Subesource Filter propagates activation. (Closed)
Patch Set: fix test, for real now Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This test creates a safebrowsing service using test safebrowsing database 5 // This test creates a safebrowsing service using test safebrowsing database
6 // and a test protocol manager. It is used to test logics in safebrowsing 6 // and a test protocol manager. It is used to test logics in safebrowsing
7 // service. 7 // service.
8 8
9 #include "chrome/browser/safe_browsing/safe_browsing_service.h" 9 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
10 10
(...skipping 911 matching lines...) Expand 10 before | Expand all | Expand 10 after
922 .Times(1); 922 .Times(1);
923 content::WebContents* web_contents = 923 content::WebContents* web_contents =
924 browser()->tab_strip_model()->GetActiveWebContents(); 924 browser()->tab_strip_model()->GetActiveWebContents();
925 subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory = 925 subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory =
926 subresource_filter::ContentSubresourceFilterDriverFactory:: 926 subresource_filter::ContentSubresourceFilterDriverFactory::
927 FromWebContents(web_contents); 927 FromWebContents(web_contents);
928 928
929 EXPECT_EQ(0U, driver_factory->activation_set().size()); 929 EXPECT_EQ(0U, driver_factory->activation_set().size());
930 chrome::NavigateParams params(browser(), bad_url, ui::PAGE_TRANSITION_LINK); 930 chrome::NavigateParams params(browser(), bad_url, ui::PAGE_TRANSITION_LINK);
931 ui_test_utils::NavigateToURL(&params); 931 ui_test_utils::NavigateToURL(&params);
932 driver_factory->ReadyToCommitMainFrameNavigation(web_contents->GetMainFrame(),
933 bad_url);
932 934
933 EXPECT_EQ(1U, driver_factory->activation_set().size()); 935 EXPECT_EQ(1U, driver_factory->activation_set().size());
934 EXPECT_TRUE(got_hit_report()); 936 EXPECT_TRUE(got_hit_report());
935 } 937 }
936 938
937 IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, SocEngReportingBlacklistEmpty) { 939 IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, SocEngReportingBlacklistEmpty) {
938 // Tests that URLS which doesn't belong to the SOCIAL_ENGINEERING_ADS threat 940 // Tests that URLS which doesn't belong to the SOCIAL_ENGINEERING_ADS threat
939 // type aren't seen by the Subresource Filter. 941 // type aren't seen by the Subresource Filter.
940 GURL bad_url = embedded_test_server()->GetURL(kMalwarePage); 942 GURL bad_url = embedded_test_server()->GetURL(kMalwarePage);
941 943
942 SBFullHashResult malware_full_hash; 944 SBFullHashResult malware_full_hash;
943 GenUrlFullHashResult(bad_url, MALWARE, &malware_full_hash); 945 GenUrlFullHashResult(bad_url, MALWARE, &malware_full_hash);
944 SetupResponseForUrl(bad_url, malware_full_hash); 946 SetupResponseForUrl(bad_url, malware_full_hash);
945 947
946 EXPECT_CALL(observer_, OnSafeBrowsingHit(IsUnsafeResourceFor(bad_url))) 948 EXPECT_CALL(observer_, OnSafeBrowsingHit(IsUnsafeResourceFor(bad_url)))
947 .Times(1); 949 .Times(1);
948 content::WebContents* web_contents = 950 content::WebContents* web_contents =
949 browser()->tab_strip_model()->GetActiveWebContents(); 951 browser()->tab_strip_model()->GetActiveWebContents();
950 subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory = 952 subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory =
951 subresource_filter::ContentSubresourceFilterDriverFactory:: 953 subresource_filter::ContentSubresourceFilterDriverFactory::
952 FromWebContents(web_contents); 954 FromWebContents(web_contents);
953 955
954 EXPECT_EQ(0U, driver_factory->activation_set().size()); 956 EXPECT_EQ(0U, driver_factory->activation_set().size());
955 chrome::NavigateParams params(browser(), bad_url, ui::PAGE_TRANSITION_LINK); 957 chrome::NavigateParams params(browser(), bad_url, ui::PAGE_TRANSITION_LINK);
956 ui_test_utils::NavigateToURL(&params); 958 ui_test_utils::NavigateToURL(&params);
959 driver_factory->ReadyToCommitMainFrameNavigation(web_contents->GetMainFrame(),
960 bad_url);
957 961
958 EXPECT_EQ(0U, driver_factory->activation_set().size()); 962 EXPECT_EQ(0U, driver_factory->activation_set().size());
959 EXPECT_TRUE(got_hit_report()); 963 EXPECT_TRUE(got_hit_report());
960 } 964 }
961 965
962 IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, 966 IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest,
963 SubResourceHitWithMainFrameReferrer) { 967 SubResourceHitWithMainFrameReferrer) {
964 GURL first_url = embedded_test_server()->GetURL(kEmptyPage); 968 GURL first_url = embedded_test_server()->GetURL(kEmptyPage);
965 GURL second_url = embedded_test_server()->GetURL(kMalwarePage); 969 GURL second_url = embedded_test_server()->GetURL(kMalwarePage);
966 GURL bad_url = embedded_test_server()->GetURL(kMalwareImg); 970 GURL bad_url = embedded_test_server()->GetURL(kMalwareImg);
(...skipping 799 matching lines...) Expand 10 before | Expand all | Expand 10 after
1766 content::Source<SafeBrowsingDatabaseManager>( 1770 content::Source<SafeBrowsingDatabaseManager>(
1767 sb_factory_->test_safe_browsing_service()->database_manager().get())); 1771 sb_factory_->test_safe_browsing_service()->database_manager().get()));
1768 BrowserThread::PostTask( 1772 BrowserThread::PostTask(
1769 BrowserThread::IO, FROM_HERE, 1773 BrowserThread::IO, FROM_HERE,
1770 base::Bind(&SafeBrowsingDatabaseManagerCookieTest::ForceUpdate, 1774 base::Bind(&SafeBrowsingDatabaseManagerCookieTest::ForceUpdate,
1771 base::Unretained(this))); 1775 base::Unretained(this)));
1772 observer.Wait(); 1776 observer.Wait();
1773 } 1777 }
1774 1778
1775 } // namespace safe_browsing 1779 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698