Store only locale paks rather than all assets within BuildConfig.java

Store only locale paks rather than all assets within BuildConfig.java

This works around Monochrome having diffferent BuildConfig.java for
32/64 bit.

BUG=652984
Committed: https://crrev.com/4e09dacc10a8a359785c6f49d75653ce7cfd00ec
Cr-Commit-Position: refs/heads/master@{#423587}

[agrieve, 2016-10-06 15:05:55]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 15:06:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-10-06 15:07:18]

agrieve@chromium.org changed reviewers:
+ michaelbai@chromium.org, tedchoc@chromium.org

[Ted C, 2016-10-06 16:41:15]

lgtm w/ comment

https://codereview.chromium.org/2396073002/diff/1/ui/android/java/src/org/chr...
File ui/android/java/src/org/chromium/ui/base/ResourceBundle.java (right):

https://codereview.chromium.org/2396073002/diff/1/ui/android/java/src/org/chr...
ui/android/java/src/org/chromium/ui/base/ResourceBundle.java:24: return
"assets/" + locale + ".pak";
Should this be the more verbose, but maybe slightly more correct:

ASSETS_DIR + File.separator + locale + ".pak"

[commit-bot: I haz the power, 2016-10-06 16:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 16:43:42]

Dry run: Exceeded global retry quota

[agrieve, 2016-10-06 17:06:00]

https://codereview.chromium.org/2396073002/diff/1/ui/android/java/src/org/chr...
File ui/android/java/src/org/chromium/ui/base/ResourceBundle.java (right):

https://codereview.chromium.org/2396073002/diff/1/ui/android/java/src/org/chr...
ui/android/java/src/org/chromium/ui/base/ResourceBundle.java:24: return
"assets/" + locale + ".pak";
On 2016/10/06 16:41:15, Ted C wrote:
> Should this be the more verbose, but maybe slightly more correct:
> 
> ASSETS_DIR + File.separator + locale + ".pak"

I believe slashes within zip files are always /, so File.separator is actually a
bit less correct.

Zapped the constant above though... meant to do that.

[agrieve, 2016-10-06 17:06:07]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-10-06 17:06:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2396073002/#ps20001
(title: "remove unused constant")

[commit-bot: I haz the power, 2016-10-06 17:06:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelbai, 2016-10-06 17:57:15]

lgtm

[commit-bot: I haz the power, 2016-10-06 18:05:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 18:07:44]

Description was changed from

==========
Store only locale paks rather than all assets within BuildConfig.java

This works around Monochrome having diffferent BuildConfig.java for
32/64 bit.

BUG=652984
==========

to

==========
Store only locale paks rather than all assets within BuildConfig.java

This works around Monochrome having diffferent BuildConfig.java for
32/64 bit.

BUG=652984

Committed: https://crrev.com/4e09dacc10a8a359785c6f49d75653ce7cfd00ec
Cr-Commit-Position: refs/heads/master@{#423587}
==========

[commit-bot: I haz the power, 2016-10-06 18:07:44]

Patchset 2 (id:??) landed as
https://crrev.com/4e09dacc10a8a359785c6f49d75653ce7cfd00ec
Cr-Commit-Position: refs/heads/master@{#423587}

[sgurun-gerrit only, 2016-10-10 22:49:48]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2404043002/ by sgurun@chromium.org.

The reason for reverting is: Breaking monochrome (chrome not booting up)

BUG=652984, 653771.