Issue 239603006: Oilpan: fix build after r171701

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239603006: Oilpan: fix build after r171701 (Closed)

Created:
6 years, 8 months ago by sof

Modified:
6 years, 8 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, Yoav Weiss, eseidel

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: fix build after r171701 NOTRY=true BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171724

Patch Set 1 #

Patch Set 2 : Make that RefPtrWillBeRawPtr #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	Source/core/css/parser/SizesAttributeParser.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
	M	Source/core/css/parser/SizesAttributeParser.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/239603006/20001

6 years, 8 months ago (2014-04-16 01:13:03 UTC) #4

hayato

6 years, 8 months ago (2014-04-16 06:39:56 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/239863003/ by hayato@chromium.org.

The reason for reverting is: [blink gardening] 

This patch is on the top of https://codereview.chromium.org/224733011, which I
am going to revert after this reverting.

See the comment of https://codereview.chromium.org/224733011 for the revert..

Expand Messages | Collapse Messages