Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2395963002: Web Share: Remove dead code for showing a warning prompt in incognito. (Closed)

Created:
4 years, 2 months ago by Matt Giuca
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Share: Remove dead code for showing a warning prompt in incognito. This reverts commit 7db85418178d9d4f01a7901da7450e40e08414ec (https://crrev.com/420564). The feature has previously been disabled, so this change should not affect behaviour. BUG=645007 Committed: https://crrev.com/850d38c2fcc1a887aa0f38319eb1b8f7f03ca169 Cr-Commit-Position: refs/heads/master@{#424323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -78 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java View 2 chunks +15 lines, -28 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java View 4 chunks +13 lines, -50 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Matt Giuca
Hi Ted, Follow-up to https://codereview.chromium.org/2389393004 (non urgent).
4 years, 2 months ago (2016-10-07 02:17:48 UTC) #2
Ted C
lgtm
4 years, 2 months ago (2016-10-10 21:54:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395963002/1
4 years, 2 months ago (2016-10-11 00:43:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 01:15:37 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 01:22:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/850d38c2fcc1a887aa0f38319eb1b8f7f03ca169
Cr-Commit-Position: refs/heads/master@{#424323}

Powered by Google App Engine
This is Rietveld 408576698