Web Share: Disable warning when web share is used from incognito.

Web Share: Disable warning when web share is used from incognito.

This was deemed unnecessary in UX review. When navigator.share is used
from incognito, you still see the intent picker which is considered
sufficient warning for users.

The bulk of the code to support this (https://crrev.com/420564) remains
and will be removed in a future CL.

BUG=645007
Committed: https://crrev.com/e27d189dc63ecb32c2645828557389de11e7a466
Cr-Commit-Position: refs/heads/master@{#423740}

[Matt Giuca, 2016-10-06 00:19:55]

mgiuca@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Matt Giuca, 2016-10-06 00:19:55]

Hi Ted, I will CC you the relevant email.

[Matt Giuca, 2016-10-06 00:23:24]

The full revert CL is in https://codereview.chromium.org/2395963002, but to
avoid churn around branch point, I decided to do a quick disable CL first, and
will send the full CL out later on.

[Ted C, 2016-10-06 17:52:40]

lgtm

To be overly cautious, what happens if you do Intent.createChooser for an intent
that only resolves to a single activity?

Will that skip the chooser or will it still show a chooser with a single entity?

We'd probably have to write a test sender and receiver app that uses an obscure
mimetype or path or something in the share intent to verify.

[Matt Giuca, 2016-10-06 23:05:29]

On 2016/10/06 17:52:40, Ted C wrote:
> lgtm
> 
> To be overly cautious, what happens if you do Intent.createChooser for an
intent
> that only resolves to a single activity?
> 
> Will that skip the chooser or will it still show a chooser with a single
entity?

There is always a chooser:
https://bugs.chromium.org/p/chromium/issues/detail?id=645007#c6

This is documented in
https://developer.android.com/training/sharing/send.html#send-text-content

> We'd probably have to write a test sender and receiver app that uses an
obscure
> mimetype or path or something in the share intent to verify.

Well I was able to manually verify using CATEGORY_BROWSABLE, but I can't think
of a way to automatically test this. (In fact, I don't have any tests that use
the real intent picker at all; too brittle to rely on the Android system UI in
tests.)

[Matt Giuca, 2016-10-06 23:05:39]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2016-10-06 23:06:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 23:42:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-06 23:43:20]

Description was changed from

==========
Web Share: Disable warning when web share is used from incognito.

This was deemed unnecessary in UX review. When navigator.share is used
from incognito, you still see the intent picker which is considered
sufficient warning for users.

The bulk of the code to support this (https://crrev.com/420564) remains
and will be removed in a future CL.

BUG=645007
==========

to

==========
Web Share: Disable warning when web share is used from incognito.

This was deemed unnecessary in UX review. When navigator.share is used
from incognito, you still see the intent picker which is considered
sufficient warning for users.

The bulk of the code to support this (https://crrev.com/420564) remains
and will be removed in a future CL.

BUG=645007

Committed: https://crrev.com/e27d189dc63ecb32c2645828557389de11e7a466
Cr-Commit-Position: refs/heads/master@{#423740}
==========

[commit-bot: I haz the power, 2016-10-06 23:43:21]

Patchset 1 (id:??) landed as
https://crrev.com/e27d189dc63ecb32c2645828557389de11e7a466
Cr-Commit-Position: refs/heads/master@{#423740}

[Ted C, 2016-10-06 23:49:18]

On 2016/10/06 23:05:29, Matt Giuca wrote:
> On 2016/10/06 17:52:40, Ted C wrote:
> > lgtm
> > 
> > To be overly cautious, what happens if you do Intent.createChooser for an
> intent
> > that only resolves to a single activity?
> > 
> > Will that skip the chooser or will it still show a chooser with a single
> entity?
> 
> There is always a chooser:
> https://bugs.chromium.org/p/chromium/issues/detail?id=645007#c6
> 
> This is documented in
> https://developer.android.com/training/sharing/send.html#send-text-content
> 
> > We'd probably have to write a test sender and receiver app that uses an
> obscure
> > mimetype or path or something in the share intent to verify.
> 
> Well I was able to manually verify using CATEGORY_BROWSABLE, but I can't think
> of a way to automatically test this. (In fact, I don't have any tests that use
> the real intent picker at all; too brittle to rely on the Android system UI in
> tests.)

I don't think we need a test for it, I think they fact that you verified
manually on the bug is more than sufficient.  Thanks!