Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2395913003: Cleanup of passing GpuMemoryBuffer backed video frames (Closed)

Created:
4 years, 2 months ago by emircan
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup of passing GpuMemoryBuffer backed video frames This is CL #2 of 2 for cleaning up GpuMemoryBuffer usage for video capture. This project is superseded by capture using mojo. This CL cleans up: - VideoFrame::StorageType enum STORAGE_GPU_MEMORY_BUFFERS - IPC messages added for passing GMB backed frames -- From browser to renderer -- From renderer to gpu I opened a bug to remove gpu::SyncToken usage on crbug.com/653994. That is also dead code but not related to GMBs, so leaving it for a separate CL. BUG=440843, 653579 Committed: https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690 Cr-Commit-Position: refs/heads/master@{#424072}

Patch Set 1 : #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -399 lines) Patch
M content/browser/renderer_host/media/video_capture_controller.cc View 2 chunks +8 lines, -28 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_event_handler.h View 2 chunks +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/media/video_capture_messages.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/video_capture_impl.h View 1 4 chunks +0 lines, -10 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 9 chunks +14 lines, -134 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.h View 1 3 chunks +0 lines, -15 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.cc View 1 2 chunks +0 lines, -19 lines 0 comments Download
M content/renderer/media/video_capture_message_filter_unittest.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/video_track_adapter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_video_frame_adapter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/video_frame.h View 5 chunks +1 line, -28 lines 0 comments Download
M media/base/video_frame.cc View 4 chunks +0 lines, -48 lines 0 comments Download
M media/gpu/ipc/client/gpu_video_encode_accelerator_host.h View 2 chunks +0 lines, -3 lines 0 comments Download
M media/gpu/ipc/client/gpu_video_encode_accelerator_host.cc View 4 chunks +1 line, -31 lines 0 comments Download
M media/gpu/ipc/common/media_messages.h View 2 chunks +0 lines, -15 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_encode_accelerator.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_encode_accelerator.cc View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 40 (31 generated)
emircan
PTAL.
4 years, 2 months ago (2016-10-07 19:01:14 UTC) #17
chfremer
lgtm % bots
4 years, 2 months ago (2016-10-07 19:52:38 UTC) #20
mcasas
On 2016/10/07 19:52:38, chfremer wrote: > lgtm % bots lgtm, ship it
4 years, 2 months ago (2016-10-07 22:14:03 UTC) #23
emircan
Adding for OWNERs review tsepez@ can you PTAL at content/common/media/video_capture_messages.h and media/gpu/ipc/common/media_messages.h? sandersd@ can you ...
4 years, 2 months ago (2016-10-07 22:21:28 UTC) #25
Tom Sepez
messages LGTM.
4 years, 2 months ago (2016-10-07 22:32:40 UTC) #26
sandersd (OOO until July 31)
media/ lgtm.
4 years, 2 months ago (2016-10-07 22:36:58 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395913003/100001
4 years, 2 months ago (2016-10-08 05:50:14 UTC) #36
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 2 months ago (2016-10-08 05:55:53 UTC) #38
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 05:57:23 UTC) #40
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690
Cr-Commit-Position: refs/heads/master@{#424072}

Powered by Google App Engine
This is Rietveld 408576698