content/renderer/media/gpu/rtc_video_encoder.cc - Issue 2395913003: Cleanup of passing GpuMemoryBuffer backed video frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/gpu/rtc_video_encoder.cc

Issue 2395913003: Cleanup of passing GpuMemoryBuffer backed video frames (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/gpu/rtc_video_encoder.cc

diff --git a/content/renderer/media/gpu/rtc_video_encoder.cc b/content/renderer/media/gpu/rtc_video_encoder.cc

index 7ab7e1c6bdabfc170e81db0f4a172699b5e40521..34b920d9740e8be9b87271bb77a4893575bb2718 100644

--- a/content/renderer/media/gpu/rtc_video_encoder.cc

+++ b/content/renderer/media/gpu/rtc_video_encoder.cc

@@ -565,7 +565,8 @@ void RTCVideoEncoder::Impl::EncodeOneFrame() {

if (next_frame->video_frame_buffer()->native_handle()) {

frame = static_cast<media::VideoFrame*>(

next_frame->video_frame_buffer()->native_handle());

- requires_copy = RequiresSizeChange(frame);

+ requires_copy = RequiresSizeChange(frame) ||

+ frame->storage_type() != media::VideoFrame::STORAGE_SHMEM;

} else {

requires_copy = true;

}