Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2395883003: Not For Review - using dom-repeat (Closed)

Created:
4 years, 2 months ago by dschuyler
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Not For Review - using dom-repeat This is a variant of https://codereview.chromium.org/2391253002/ showing a difference of generating HTML elements in JS vs generating a data array and using dom-repeat. Example using dom-repeat rather than generating nodes from JS.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -46 lines) Patch
M chrome/app/settings_strings.grdp View 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 3 chunks +8 lines, -13 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/cookie_tree_node.js View 4 chunks +18 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data.html View 3 chunks +20 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data.js View 2 chunks +45 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data_details_dialog.html View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data_details_dialog.js View 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details.html View 3 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details.js View 8 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/cookies_tree_model_util.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/cookies_tree_model_util.cc View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
dschuyler
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-05 21:37:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395883003/1
4 years, 2 months ago (2016-10-05 21:37:37 UTC) #2
dschuyler
Description was changed from ========== Not For Review - using dom-repeat Example using dom-repeat rather ...
4 years, 2 months ago (2016-10-05 22:03:53 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-05 22:49:56 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 22:49:56 UTC) #5 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698