Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2795)

Unified Diff: chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

Issue 2395883003: Not For Review - using dom-repeat (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
diff --git a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
index 9bfbdb0b6dc5c89d0975233f400c4a906509c776..c5c02c75d7e292dcdd48452689807bd0367b134a 100644
--- a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
+++ b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
@@ -42,6 +42,8 @@ Polymer({
* @type {?WebUIListener}
*/
listener_: Object,
+
+ cookieNodes_: Object,
},
/**
@@ -118,16 +120,9 @@ Polymer({
* @private
*/
populateItem_: function(id, site) {
- // Out with the old...
- var root = this.$.content;
- while (root.lastChild) {
- root.removeChild(root.lastChild);
- }
-
- // In with the new...
var node = site.fetchNodeById(id, true);
if (node)
- site.addCookieData(root, node);
+ this.cookieNodes_ = site.getCookieData(node);
},
/**
@@ -171,7 +166,7 @@ Polymer({
// of '1 cookie', '1 cookie', ... etc, it is better to show the title of the
// cookie to differentiate them.
if (item.data.type == 'cookie')
- return item.title;
+ return loadTimeData.getStringF('siteSettingsCookie', item.title);
return getCookieDataCategoryText(item.data.type, item.data.totalUsage);
},

Powered by Google App Engine
This is Rietveld 408576698