third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.cpp - Issue 2395853003: [Sensors] Improvements in shared buffer managing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.cpp

Issue 2395853003: [Sensors] Improvements in shared buffer managing (Closed)

Patch Set: Pass task runner to PlatformSensor constructor Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/generic_sensor/public/interfaces/sensor_provider.mojom ('K') | « third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js ('k') | third_party/WebKit/Source/modules/sensor/BUILD.gn » ('j') | third_party/WebKit/Source/modules/sensor/SensorProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.cpp

diff --git a/third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.cpp b/third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.cpp

index 74efa7b19b239be99da4cb6b26fc9e4a58ef8a71..0589ba7ccca829158ca8689a511304f22317e1b2 100644

--- a/third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.cpp

+++ b/third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.cpp

@@ -24,14 +24,14 @@ double AmbientLightSensorReading::illuminance() const {

if (!m_sensorProxy)

return 0.0;

- return m_sensorProxy->reading().reading[0];

+ return m_sensorProxy->reading().values[0];

}

bool AmbientLightSensorReading::isReadingUpdated(

const SensorProxy::Reading& previous) const {

if (!m_sensorProxy)

return false;

- return previous.reading[0] != illuminance();

+ return previous.values[0] != illuminance();

}

DEFINE_TRACE(AmbientLightSensorReading) {