Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2696)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: device/generic_sensor/public/interfaces/sensor_provider.mojom

Issue 2395853003: [Sensors] Improvements in shared buffer managing (Closed)
Patch Set: Pass task runner to PlatformSensor constructor Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« device/generic_sensor/public/cpp/sensor_reading.h ('K') | « device/generic_sensor/public/cpp/sensor_reading.cc ('k') | device/generic_sensor/sensor_provider_impl.cc » ('j') | third_party/WebKit/Source/modules/sensor/SensorProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/generic_sensor/public/interfaces/sensor_provider.mojom
diff --git a/device/generic_sensor/public/interfaces/sensor_provider.mojom b/device/generic_sensor/public/interfaces/sensor_provider.mojom
index b7e4d2b9caaa6e6ff6b30255165adefece7a4b28..c4a1392756803a5b59bb9aaa53f2f3e38377159d 100644
--- a/device/generic_sensor/public/interfaces/sensor_provider.mojom
+++ b/device/generic_sensor/public/interfaces/sensor_provider.mojom
@@ -19,10 +19,10 @@ struct SensorInitParams {
// Default sensor configuration.
SensorConfiguration default_configuration;
- // Note: Each sensor's read buffer contains 4 tightly packed 64-bit floating
- // point fields, its layout is: { double timestamp; double values[3] }.
- // So it has a fixed size 4*8 = 32 bytes.
- const uint64 kReadBufferSize = 32;
+ // Each sensor's read buffer contains 4 tightly packed 64-bit floating
+ // point fields (pls see sensor_reading.h) and a seqlock, so its size is
Ken Rockot(use gerrit already) 2016/10/10 16:02:08 nit: "please"
Mikhail 2016/10/10 18:29:20 Done.
+ // 5 * 8 = 40 bytes.
+ const uint64 kReadBufferSizeForTests = 40;
};
interface SensorProvider {
« device/generic_sensor/public/cpp/sensor_reading.h ('K') | « device/generic_sensor/public/cpp/sensor_reading.cc ('k') | device/generic_sensor/sensor_provider_impl.cc » ('j') | third_party/WebKit/Source/modules/sensor/SensorProxy.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698