third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html - Issue 2395853003: [Sensors] Improvements in shared buffer managing

Side by Side Diff: third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html

Issue 2395853003: [Sensors] Improvements in shared buffer managing (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensor.java ('K') | « device/generic_sensor/sensor_provider_impl.cc ('k') | third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js » ('j') | third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <script src="../resources/mojo-helpers.js"></script>	4 <script src="../resources/mojo-helpers.js"></script>

5 <script src="resources/sensor-helpers.js"></script>	5 <script src="resources/sensor-helpers.js"></script>

6 <script>	6 <script>

7	7

8 'use strict';	8 'use strict';

9	9

10 if (!window.testRunner)	10 if (!window.testRunner)

11 debug('This test cannot be run without the TestRunner');	11 debug('This test cannot be run without the TestRunner');

12	12

13 const kDefaultReadingValue = 3.1415;	13 const kDefaultReadingValue = 3.1415;

14	14

15 function update_sensor_reading(buffer) {	15 function update_sensor_reading(buffer) {

16 buffer[0] = window.performance.now();	16 buffer[0] = 0.0; // Placeholder for seqlock.
	shalamov 2016/10/06 12:46:09 Maybe better to make resetBuffer() function in sen Maybe better to make resetBuffer() function in sensor-helpers.js and then call it after this.buffer_ = new Float64Array(this.buffer_array_); and also reuse it in reset(); resetBuffer() for (let i = 0; i < this.buffer_.length; ++i) { this.buffer_[i] = 0; } } Then, you can remove buffer[0] = 0.0; // Placeholder for seqlock. and start writing values starting from buffer[1]... Mikhail 2016/10/07 10:07:02 Done. Show quoted text On 2016/10/06 12:46:09, shalamov wrote: > Maybe better to make resetBuffer() function in sensor-helpers.js and then call > it after this.buffer_ = new Float64Array(this.buffer_array_); > and also reuse it in reset(); > > resetBuffer() > for (let i = 0; i < this.buffer_.length; ++i) { > this.buffer_[i] = 0; > } > } > > Then, you can remove buffer[0] = 0.0; // Placeholder for seqlock. and start > writing values starting from buffer[1]... Done.
17 buffer[1] = kDefaultReadingValue;	17 buffer[1] = window.performance.now();

	18 buffer[2] = kDefaultReadingValue;

18 }	19 }

19	20

20 test(() => assert_throws(	21 test(() => assert_throws(

21 new RangeError(),	22 new RangeError(),

22 () => new AmbientLightSensor({frequency: -60})),	23 () => new AmbientLightSensor({frequency: -60})),

23 'Test that negative frequency causes exception from constructor.');	24 'Test that negative frequency causes exception from constructor.');

24	25

25 sensor_test(sensor => {	26 sensor_test(sensor => {

26 sensor.mockSensorProvider.setGetSensorShouldFail(true);	27 sensor.mockSensorProvider.setGetSensorShouldFail(true);

27 let ambientLightSensor = new AmbientLightSensor();	28 let ambientLightSensor = new AmbientLightSensor();

(...skipping 196 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
224 ambientLightSensor.onerror = reject;	225 ambientLightSensor.onerror = reject;

225 });	226 });

226 })	227 })

227 .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });	228 .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });

228	229

229 return testPromise;	230 return testPromise;

230 }, 'Test that sensor receives suspend / resume notifications when page'	231 }, 'Test that sensor receives suspend / resume notifications when page'

231 +' visibility changes.');	232 +' visibility changes.');

232	233

233 </script>	234 </script>

OLD	NEW