Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Side by Side Diff: device/generic_sensor/sensor_provider_impl.cc

Issue 2395853003: [Sensors] Improvements in shared buffer managing (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/generic_sensor/sensor_provider_impl.h" 5 #include "device/generic_sensor/sensor_provider_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "device/generic_sensor/platform_sensor_provider.h" 9 #include "device/generic_sensor/platform_sensor_provider.h"
10 #include "device/generic_sensor/sensor_impl.h" 10 #include "device/generic_sensor/sensor_impl.h"
11 #include "mojo/public/cpp/bindings/strong_binding.h" 11 #include "mojo/public/cpp/bindings/strong_binding.h"
12 12
13 namespace device { 13 namespace device {
14 14
15 namespace {
16
17 uint64_t GetBufferOffset(mojom::SensorType type) {
18 return (static_cast<uint64_t>(mojom::SensorType::LAST) -
19 static_cast<uint64_t>(type)) *
20 mojom::SensorInitParams::kReadBufferSize;
21 }
22
23 } // namespace
24
25 // static 15 // static
26 void SensorProviderImpl::Create(mojom::SensorProviderRequest request) { 16 void SensorProviderImpl::Create(mojom::SensorProviderRequest request) {
27 PlatformSensorProvider* provider = PlatformSensorProvider::GetInstance(); 17 PlatformSensorProvider* provider = PlatformSensorProvider::GetInstance();
28 if (provider) { 18 if (provider) {
29 mojo::MakeStrongBinding(base::WrapUnique(new SensorProviderImpl(provider)), 19 mojo::MakeStrongBinding(base::WrapUnique(new SensorProviderImpl(provider)),
30 std::move(request)); 20 std::move(request));
31 } 21 }
32 } 22 }
33 23
34 SensorProviderImpl::SensorProviderImpl(PlatformSensorProvider* provider) 24 SensorProviderImpl::SensorProviderImpl(PlatformSensorProvider* provider)
35 : provider_(provider) { 25 : provider_(provider) {
36 DCHECK(provider_); 26 DCHECK(provider_);
37 } 27 }
38 28
39 SensorProviderImpl::~SensorProviderImpl() {} 29 SensorProviderImpl::~SensorProviderImpl() {}
40 30
41 void SensorProviderImpl::GetSensor(mojom::SensorType type, 31 void SensorProviderImpl::GetSensor(mojom::SensorType type,
42 mojom::SensorRequest sensor_request, 32 mojom::SensorRequest sensor_request,
43 const GetSensorCallback& callback) { 33 const GetSensorCallback& callback) {
44 auto cloned_handle = provider_->CloneSharedBufferHandle(); 34 auto cloned_handle = provider_->CloneSharedBufferHandle();
45 if (!cloned_handle.is_valid()) { 35 if (!cloned_handle.is_valid()) {
46 callback.Run(nullptr, nullptr); 36 callback.Run(nullptr, nullptr);
47 return; 37 return;
48 } 38 }
49 39
50 scoped_refptr<PlatformSensor> sensor = provider_->GetSensor(type); 40 scoped_refptr<PlatformSensor> sensor = provider_->GetSensor(type);
51 if (!sensor) { 41 if (!sensor) {
52 sensor = provider_->CreateSensor( 42 sensor = provider_->CreateSensor(type);
53 type, mojom::SensorInitParams::kReadBufferSize, GetBufferOffset(type));
54 } 43 }
55 44
56 if (!sensor) { 45 if (!sensor) {
57 callback.Run(nullptr, nullptr); 46 callback.Run(nullptr, nullptr);
58 return; 47 return;
59 } 48 }
60 49
61 auto sensor_impl = base::MakeUnique<SensorImpl>(sensor); 50 auto sensor_impl = base::MakeUnique<SensorImpl>(sensor);
62 51
63 auto init_params = mojom::SensorInitParams::New(); 52 auto init_params = mojom::SensorInitParams::New();
64 init_params->memory = std::move(cloned_handle); 53 init_params->memory = std::move(cloned_handle);
65 init_params->buffer_offset = GetBufferOffset(type); 54 init_params->buffer_offset = provider_->GetSharedBufferOffset(type);
66 init_params->mode = sensor->GetReportingMode(); 55 init_params->mode = sensor->GetReportingMode();
67 init_params->default_configuration = sensor->GetDefaultConfiguration(); 56 init_params->default_configuration = sensor->GetDefaultConfiguration();
68 57
69 callback.Run(std::move(init_params), sensor_impl->GetClient()); 58 callback.Run(std::move(init_params), sensor_impl->GetClient());
70 59
71 mojo::MakeStrongBinding(std::move(sensor_impl), std::move(sensor_request)); 60 mojo::MakeStrongBinding(std::move(sensor_impl), std::move(sensor_request));
72 } 61 }
73 62
74 } // namespace device 63 } // namespace device
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698