Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2395733002: Clean up .git-blame-ignore-list comments. (Closed)

Created:
4 years, 2 months ago by Matt Giuca
Modified:
4 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up .git-blame-ignore-list comments. We are seeing a lot of large blocks of commits with approx. the same comment for a single refactoring effort. Remove the per-commit comments in favour of per-project headings. Committed: https://crrev.com/b43dcccf2e7edcf8d05fd099b437e74803e3737f Cr-Commit-Position: refs/heads/master@{#423342}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -223 lines) Patch
M .git-blame-ignore-revs View 1 3 chunks +6 lines, -223 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Matt Giuca
Hi Nico, In response to https://codereview.chromium.org/2386973002 where some headings were removed, I thought it was ...
4 years, 2 months ago (2016-10-05 04:43:54 UTC) #2
Matt Giuca
Note: This needs a rebase (there's been a lot of activity on this file) but ...
4 years, 2 months ago (2016-10-05 04:44:23 UTC) #3
Nico
On 2016/10/05 04:44:23, Matt Giuca wrote: > Note: This needs a rebase (there's been a ...
4 years, 2 months ago (2016-10-05 10:51:25 UTC) #4
Nico
*after rebasing (sorry, Android Keyboard apparently autocorrects "rebasing" to "reading") On Oct 5, 2016 6:51 ...
4 years, 2 months ago (2016-10-05 11:48:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395733002/20001
4 years, 2 months ago (2016-10-05 23:32:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 23:51:13 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 23:52:50 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b43dcccf2e7edcf8d05fd099b437e74803e3737f
Cr-Commit-Position: refs/heads/master@{#423342}

Powered by Google App Engine
This is Rietveld 408576698