Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2386973002: Add comment-reflow CLs to .git-blame-ignore-revs. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comment-reflow CLs to .git-blame-ignore-revs. For the following changes: https://codereview.chromium.org/2390543002/ https://codereview.chromium.org/2390563002/ BUG=563793 NOTRY=true Committed: https://crrev.com/be15d9ac46262cd7dce12d7fde3925d79326ac77 Cr-Commit-Position: refs/heads/master@{#422993}

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase, and remove per-hash comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M .git-blame-ignore-revs View 1 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
tkent
thakis@, would you approve this please?
4 years, 2 months ago (2016-10-03 05:09:33 UTC) #2
Nico
Thanks! Lgtm with minor tweak: https://codereview.chromium.org/2386973002/diff/1/.git-blame-ignore-revs File .git-blame-ignore-revs (right): https://codereview.chromium.org/2386973002/diff/1/.git-blame-ignore-revs#newcode518 .git-blame-ignore-revs:518: da71ffa5eba20d97df583821ef5bc20778847a86 Can you add ...
4 years, 2 months ago (2016-10-03 12:00:32 UTC) #3
Nico
https://codereview.chromium.org/2386973002/diff/1/.git-blame-ignore-revs File .git-blame-ignore-revs (right): https://codereview.chromium.org/2386973002/diff/1/.git-blame-ignore-revs#newcode518 .git-blame-ignore-revs:518: da71ffa5eba20d97df583821ef5bc20778847a86 On 2016/10/03 12:00:32, Nico wrote: > Can you ...
4 years, 2 months ago (2016-10-03 21:18:47 UTC) #4
tkent
https://codereview.chromium.org/2386973002/diff/1/.git-blame-ignore-revs File .git-blame-ignore-revs (right): https://codereview.chromium.org/2386973002/diff/1/.git-blame-ignore-revs#newcode518 .git-blame-ignore-revs:518: da71ffa5eba20d97df583821ef5bc20778847a86 On 2016/10/03 at 21:18:47, Nico wrote: > On ...
4 years, 2 months ago (2016-10-04 23:11:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386973002/20001
4 years, 2 months ago (2016-10-04 23:14:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 23:21:23 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 23:23:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be15d9ac46262cd7dce12d7fde3925d79326ac77
Cr-Commit-Position: refs/heads/master@{#422993}

Powered by Google App Engine
This is Rietveld 408576698