Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2395683002: Revert of Reformat comments in core/layout up until LayoutBox (Closed)

Created:
4 years, 2 months ago by imcheng
Modified:
4 years, 2 months ago
Reviewers:
ikilpatrick, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reformat comments in core/layout up until LayoutBox (patchset #5 id:80001 of https://codereview.chromium.org/2391893004/ ) Reason for revert: May have broken webkit_tests: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/24637 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/472 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/15569 Original issue's description: > Reformat comments in core/layout up until LayoutBox > > BUG=563793 > R=ikilpatrick@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/f88ea2d39f753432656ab06970e7792f012b9104 TBR=ikilpatrick@chromium.org,eae@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563793 Committed: https://crrev.com/64f8e6ee53f1542634b9bb32cc84f2e24356fee3 Cr-Commit-Position: refs/heads/master@{#423043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1689 lines, -2291 lines) Patch
M third_party/WebKit/Source/core/layout/ClipRect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ClipRectsCache.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.h View 12 chunks +73 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.cpp View 13 chunks +48 lines, -59 lines 0 comments Download
M third_party/WebKit/Source/core/layout/CounterNode.h View 1 chunk +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/CounterNode.cpp View 5 chunks +19 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/DepthOrderedLayoutObjectList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.h View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 5 chunks +13 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FragmentainerIterator.h View 1 chunk +11 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp View 7 chunks +18 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FragmentationContext.h View 1 chunk +20 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/layout/GeneratedChildren.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestCache.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestLocation.cpp View 2 chunks +5 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestRequest.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.h View 4 chunks +20 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 4 chunks +12 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestingTransformState.h View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityController.cpp View 3 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp View 8 chunks +11 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBR.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 10 chunks +22 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 48 chunks +153 lines, -225 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 9 chunks +32 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 123 chunks +471 lines, -652 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 64 chunks +167 lines, -224 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 29 chunks +100 lines, -137 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 136 chunks +455 lines, -600 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
imcheng
Created Revert of Reformat comments in core/layout up until LayoutBox
4 years, 2 months ago (2016-10-05 01:10:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395683002/1
4 years, 2 months ago (2016-10-05 01:11:26 UTC) #3
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/layout/LayoutBox.cpp: While running git apply --index -3 -p1; error: patch ...
4 years, 2 months ago (2016-10-05 01:12:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395683002/1
4 years, 2 months ago (2016-10-05 01:32:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 01:34:01 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/64f8e6ee53f1542634b9bb32cc84f2e24356fee3 Cr-Commit-Position: refs/heads/master@{#423043}
4 years, 2 months ago (2016-10-05 01:37:01 UTC) #11
eae
LGTM, Thanks! On Tue, Oct 4, 2016 at 6:37 PM, commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: ...
4 years, 2 months ago (2016-10-05 15:13:02 UTC) #12
eae
4 years, 2 months ago (2016-10-05 15:13:03 UTC) #13
Message was sent while issue was closed.
LGTM, Thanks!

On Tue, Oct 4, 2016 at 6:37 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com>
wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/64f8e6ee53f1542634b9bb32cc84f2e24356fee3
> Cr-Commit-Position: refs/heads/master@{#423043}
>
> https://codereview.chromium.org/2395683002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698