Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2395633002: Don't pass unused options on to webkit-patch copy-existing-baselines-internal. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, chromium-reviews, Dirk Pranke, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't pass unused options on to webkit-patch copy-existing-baselines-internal. This shouldn't result in any change in behavior. The purpose of this CL is to make it clearer what arguments may be used by copy-existing-baselines-internal and which aren't. Committed: https://crrev.com/2d8b024795b5d85f4713bce269481a543e6fc5e0 Cr-Commit-Position: refs/heads/master@{#423662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 chunk +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
qyearsley
4 years, 2 months ago (2016-10-04 21:48:05 UTC) #5
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-06 18:06:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395633002/1
4 years, 2 months ago (2016-10-06 19:39:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 20:47:21 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 20:49:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d8b024795b5d85f4713bce269481a543e6fc5e0
Cr-Commit-Position: refs/heads/master@{#423662}

Powered by Google App Engine
This is Rietveld 408576698