Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 2395633002: Don't pass unused options on to webkit-patch copy-existing-baselines-internal. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index 78d3011ce956a8cf498a29b47acf6128c0065aee..37bb2cce1f2626fc2043bbbf9d4f7bdc2679774d 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -387,17 +387,21 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
continue
suffixes = ','.join(actual_failures_suffixes)
- cmd_line = ['--suffixes', suffixes, '--builder', builder, '--test', test]
- if build_number:
- cmd_line.extend(['--build-number', str(build_number)])
- if options.results_directory:
- cmd_line.extend(['--results-directory', options.results_directory])
+ args = ['--suffixes', suffixes, '--builder', builder, '--test', test]
+
if options.verbose:
- cmd_line.append('--verbose')
+ args.append('--verbose')
+
copy_baseline_commands.append(
- tuple([[self._tool.executable, path_to_webkit_patch, 'copy-existing-baselines-internal'] + cmd_line, cwd]))
+ tuple([[self._tool.executable, path_to_webkit_patch, 'copy-existing-baselines-internal'] + args, cwd]))
+
+ if build_number:
+ args.extend(['--build-number', str(build_number)])
+ if options.results_directory:
+ args.extend(['--results-directory', options.results_directory])
+
rebaseline_commands.append(
- tuple([[self._tool.executable, path_to_webkit_patch, 'rebaseline-test-internal'] + cmd_line, cwd]))
+ tuple([[self._tool.executable, path_to_webkit_patch, 'rebaseline-test-internal'] + args, cwd]))
return copy_baseline_commands, rebaseline_commands, lines_to_remove
@staticmethod
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698