Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 239563004: fix minor skp-found bugs (Closed)

Created:
6 years, 8 months ago by caryclark
Modified:
6 years, 8 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fix minor skp-found bugs remove globals from pathops_unittest BUG=skia:2460 TBR=mtklein Committed: http://code.google.com/p/skia/source/detail?r=14378

Patch Set 1 #

Patch Set 2 : remove unused code #

Patch Set 3 : work in progress; fixing broken 1m skps #

Patch Set 4 : fix blogspot infinite loop #

Patch Set 5 : fix numerous skp-found bugs; remove debug globals #

Patch Set 6 : put new experimental loop tester in right place; remove wrongly named file #

Patch Set 7 : comment out test functions that aren't ready to run #

Patch Set 8 : fix mac-detected errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1869 lines, -211 lines) Patch
M gyp/pathops_unittest.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkDCubicIntersection.cpp View 1 2 3 4 5 6 7 1 chunk +11 lines, -0 lines 0 comments Download
M src/pathops/SkDLineIntersection.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/pathops/SkDQuadLineIntersection.cpp View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M src/pathops/SkIntersections.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpAngle.h View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M src/pathops/SkOpAngle.cpp View 1 2 3 4 5 chunks +52 lines, -0 lines 0 comments Download
M src/pathops/SkOpContour.cpp View 1 2 3 chunks +10 lines, -6 lines 0 comments Download
M src/pathops/SkOpEdgeBuilder.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpSegment.h View 1 2 3 4 9 chunks +10 lines, -17 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 2 3 4 31 chunks +109 lines, -93 lines 0 comments Download
M src/pathops/SkOpSpan.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsCommon.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 2 3 4 6 chunks +14 lines, -7 lines 0 comments Download
M src/pathops/SkPathOpsCubic.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 2 3 4 4 chunks +6 lines, -4 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 2 3 4 2 chunks +14 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 1 2 3 4 2 chunks +17 lines, -4 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download
M src/pathops/SkReduceOrder.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PathOpsDebug.cpp View 1 3 chunks +6 lines, -8 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
A tests/PathOpsOpLoopThreadedTest.cpp View 1 2 3 4 5 6 7 1 chunk +103 lines, -0 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 3 4 5 6 7 6 chunks +64 lines, -17 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 2 3 4 2 chunks +0 lines, -8 lines 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 1 2 3 12 chunks +104 lines, -21 lines 0 comments Download
M tests/PathOpsSkpTest.cpp View 1 2 3 4 5 6 2 chunks +1267 lines, -0 lines 0 comments Download
M tests/PathOpsThreadedCommon.cpp View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M tools/pathops_sorter.htm View 1 2 3 4 3 chunks +51 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 8 months ago (2014-04-25 11:55:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/239563004/100001
6 years, 8 months ago (2014-04-25 11:55:57 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 12:02:03 UTC) #3
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildTests http://skia-tree-status.appspot.com/redirect/compile-buildbots/buildstatus?builder=Build-Mac10.8-Clang-x86-Release-Trybot&number=731
6 years, 8 months ago (2014-04-25 12:02:03 UTC) #4
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 8 months ago (2014-04-25 12:41:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/239563004/140001
6 years, 8 months ago (2014-04-25 12:42:14 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 12:59:20 UTC) #7
Message was sent while issue was closed. 
Change committed as 14378

Powered by Google App Engine
This is Rietveld 408576698