src/pathops/SkPathOpsCommon.h - Issue 239563004: fix minor skp-found bugs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/pathops/SkPathOpsCommon.h

Issue 239563004: fix minor skp-found bugs (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix mac-detected errors Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « src/pathops/SkOpSpan.h ('k') | src/pathops/SkPathOpsCommon.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright 2012 Google Inc.	2 * Copyright 2012 Google Inc.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license that can be	4 * Use of this source code is governed by a BSD-style license that can be

5 * found in the LICENSE file.	5 * found in the LICENSE file.

6 */	6 */

7 #ifndef SkPathOpsCommon_DEFINED	7 #ifndef SkPathOpsCommon_DEFINED

8 #define SkPathOpsCommon_DEFINED	8 #define SkPathOpsCommon_DEFINED

9	9

10 #include "SkOpAngle.h"	10 #include "SkOpAngle.h"

11 #include "SkOpContour.h"	11 #include "SkOpContour.h"

12 #include "SkTDArray.h"	12 #include "SkTDArray.h"

13	13

14 class SkPathWriter;	14 class SkPathWriter;

15	15

16 void Assemble(const SkPathWriter& path, SkPathWriter* simple);	16 void Assemble(const SkPathWriter& path, SkPathWriter* simple);

17 // FIXME: find chase uses insert, so it can't be converted to SkTArray yet	17 // FIXME: find chase uses insert, so it can't be converted to SkTArray yet

18 SkOpSegment* FindChase(SkTDArray<SkOpSpan> chase, int* tIndex, int* endIndex);	18 SkOpSegment* FindChase(SkTDArray<SkOpSpan> chase, int* tIndex, int* endIndex);

19 SkOpSegment* FindSortableTop(const SkTArray<SkOpContour*, true>& , SkOpAngle::In cludeType ,	19 SkOpSegment* FindSortableTop(const SkTArray<SkOpContour*, true>& , SkOpAngle::In cludeType ,

20 bool* firstContour, int* index, int* endIndex, SkPo int* topLeft,	20 bool* firstContour, int* index, int* endIndex, SkPo int* topLeft,

21 bool* unsortable, bool* done);	21 bool* unsortable, bool* done, bool firstPass);

22 SkOpSegment* FindUndone(SkTArray<SkOpContour, true>& contourList, int start, i nt* end);	22 SkOpSegment* FindUndone(SkTArray<SkOpContour, true>& contourList, int start, i nt* end);

23 void MakeContourList(SkTArray<SkOpContour>& contours, SkTArray<SkOpContour*, tru e>& list,	23 void MakeContourList(SkTArray<SkOpContour>& contours, SkTArray<SkOpContour*, tru e>& list,

24 bool evenOdd, bool oppEvenOdd);	24 bool evenOdd, bool oppEvenOdd);

25 bool HandleCoincidence(SkTArray<SkOpContour, true> , int );	25 bool HandleCoincidence(SkTArray<SkOpContour, true> , int );

26	26

27 #if DEBUG_ACTIVE_SPANS \|\| DEBUG_ACTIVE_SPANS_FIRST_ONLY	27 #if DEBUG_ACTIVE_SPANS \|\| DEBUG_ACTIVE_SPANS_FIRST_ONLY

28 void DebugShowActiveSpans(SkTArray<SkOpContour*, true>& contourList);	28 void DebugShowActiveSpans(SkTArray<SkOpContour*, true>& contourList);

29 #endif	29 #endif

30	30

31 #endif	31 #endif

OLD	NEW