chromeos: Refactor system tray "show settings" commands to use mojo

chromeos: Refactor system tray "show settings" commands to use mojo

Change the pattern of delegation to chrome to use mojom::SystemTrayClient.
This is more consistent with how we want to handle ash delegates going
forward. It eliminates a couple layers of indirection.

* Add wrapper methods to SystemTrayController in ash
* Remove Show* methods from SystemTrayDelegate in ash
* Delete SystemTrayCommon in chrome, move code to SystemTrayClient

Also delete unused tray_display.cc, left over from another cleanup CL
https://codereview.chromium.org/2217713002

BUG=647412
TEST=existing browser_tests, manually verifying system tray help and
settings buttons open web UI in chrome

Committed: https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb
Cr-Commit-Position: refs/heads/master@{#422857}

[James Cook, 2016-10-04 17:07:08]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-10-04 17:07:29]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-10-04 17:07:29]

msw, please take a look

[commit-bot: I haz the power, 2016-10-04 17:07:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-10-04 17:29:00]

lgtm with a nit

https://codereview.chromium.org/2395523002/diff/1/chrome/browser/ui/ash/syste...
File chrome/browser/ui/ash/system_tray_client.cc (right):

https://codereview.chromium.org/2395523002/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_client.cc:20: #include
"chrome/common/url_constants.h"
nit: remove if not used

[James Cook, 2016-10-04 17:54:11]

https://codereview.chromium.org/2395523002/diff/1/chrome/browser/ui/ash/syste...
File chrome/browser/ui/ash/system_tray_client.cc (right):

https://codereview.chromium.org/2395523002/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_client.cc:20: #include
"chrome/common/url_constants.h"
On 2016/10/04 17:29:00, msw wrote:
> nit: remove if not used

Sadly, used for various k*SubPage constants, which would be more obvious if they
were in a namespace like url_constants:: :-(

[James Cook, 2016-10-04 17:54:19]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-10-04 17:54:24]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-10-04 17:54:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 18:06:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 18:10:01]

Description was changed from

==========
chromeos: Refactor system tray "show settings" commands to use mojo

Change the pattern of delegation to chrome to use mojom::SystemTrayClient.
This is more consistent with how we want to handle ash delegates going
forward. It eliminates a couple layers of indirection.

* Add wrapper methods to SystemTrayController in ash
* Remove Show* methods from SystemTrayDelegate in ash
* Delete SystemTrayCommon in chrome, move code to SystemTrayClient

Also delete unused tray_display.cc, left over from another cleanup CL
https://codereview.chromium.org/2217713002

BUG=647412
TEST=existing browser_tests, manually verifying system tray help and
settings buttons open web UI in chrome
==========

to

==========
chromeos: Refactor system tray "show settings" commands to use mojo

Change the pattern of delegation to chrome to use mojom::SystemTrayClient.
This is more consistent with how we want to handle ash delegates going
forward. It eliminates a couple layers of indirection.

* Add wrapper methods to SystemTrayController in ash
* Remove Show* methods from SystemTrayDelegate in ash
* Delete SystemTrayCommon in chrome, move code to SystemTrayClient

Also delete unused tray_display.cc, left over from another cleanup CL
https://codereview.chromium.org/2217713002

BUG=647412
TEST=existing browser_tests, manually verifying system tray help and
settings buttons open web UI in chrome

Committed: https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb
Cr-Commit-Position: refs/heads/master@{#422857}
==========

[commit-bot: I haz the power, 2016-10-04 18:10:02]

Patchset 1 (id:??) landed as
https://crrev.com/4dd7585b13a7fc40276b36efd33e85177aa45ebb
Cr-Commit-Position: refs/heads/master@{#422857}