Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: ash/common/system/tray/system_tray_delegate.h

Issue 2395523002: chromeos: Refactor system tray "show settings" commands to use mojo (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/tray/system_tray_delegate.h
diff --git a/ash/common/system/tray/system_tray_delegate.h b/ash/common/system/tray/system_tray_delegate.h
index df316aeb96764816c4f31c0f49f4cf1be5579f60..9751f556c87aad3189b0608e4871c6068633213f 100644
--- a/ash/common/system/tray/system_tray_delegate.h
+++ b/ash/common/system/tray/system_tray_delegate.h
@@ -144,9 +144,6 @@ class ASH_EXPORT SystemTrayDelegate {
// Fills |info| structure (which must not be null) with current update info.
virtual void GetSystemUpdateInfo(UpdateInfo* info) const;
- // Shows settings.
- virtual void ShowSettings();
-
// Returns true if settings menu item should appear.
virtual bool ShouldShowSettings();
@@ -157,40 +154,10 @@ class ASH_EXPORT SystemTrayDelegate {
// show the settings for the corresponding network.
virtual void ShowNetworkSettingsForGuid(const std::string& guid);
- // Shows settings related to multiple displays.
- virtual void ShowDisplaySettings();
-
- // Shows settings related to power.
- virtual void ShowPowerSettings();
-
- // Shows the page that lets you disable performance tracing.
- virtual void ShowChromeSlow();
-
// Returns true if the notification for the display configuration change
// should appear.
virtual bool ShouldShowDisplayNotification();
- // Shows settings related to input methods.
- virtual void ShowIMESettings();
-
- // Shows help.
- virtual void ShowHelp();
-
- // Show accessilibity help.
- virtual void ShowAccessibilityHelp();
-
- // Show the settings related to accessilibity.
- virtual void ShowAccessibilitySettings();
-
- // Shows the help center article for palette.
- virtual void ShowPaletteHelp();
-
- // Shows the settings related to the palette.
- virtual void ShowPaletteSettings();
-
- // Shows more information about public account mode.
- virtual void ShowPublicAccountInfo();
-
// Shows information about enterprise enrolled devices.
virtual void ShowEnterpriseInfo();
@@ -255,9 +222,6 @@ class ASH_EXPORT SystemTrayDelegate {
// Returns whether the delegate has initiated a bluetooth discovery session.
virtual bool GetBluetoothDiscovering();
- // Shows UI for changing proxy settings.
- virtual void ShowProxySettings();
-
// Returns CastConfigDelegate. May return nullptr.
virtual CastConfigDelegate* GetCastConfigDelegate();

Powered by Google App Engine
This is Rietveld 408576698