Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 2395473002: reflow comments in modules/webdatabase (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
michaeln, haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in modules/webdatabase BUG=563793 Committed: https://crrev.com/b873e02f086898e946c374f628fdc7b1cb47ce37 Cr-Commit-Position: refs/heads/master@{#422884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -242 lines) Patch
M third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp View 1 chunk +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseClient.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseContext.cpp View 3 chunks +15 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseTask.cpp View 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseThread.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLResultSet.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp View 5 chunks +44 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.cpp View 22 chunks +174 lines, -131 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionClient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionClient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.h View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp View 4 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp View 4 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteTransaction.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Nico
4 years, 2 months ago (2016-10-04 14:19:34 UTC) #3
michaeln
r/s lgtm (hooray line length sanity!)
4 years, 2 months ago (2016-10-04 19:12:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395473002/1
4 years, 2 months ago (2016-10-04 19:21:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 19:27:31 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b873e02f086898e946c374f628fdc7b1cb47ce37 Cr-Commit-Position: refs/heads/master@{#422884}
4 years, 2 months ago (2016-10-04 19:31:21 UTC) #12
haraken
4 years, 2 months ago (2016-10-05 01:14:32 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698