Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp

Issue 2395473002: reflow comments in modules/webdatabase (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webdatabase/DatabaseClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp
diff --git a/third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp b/third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp
index 1236cc2edcb4d1829dcb54c74b5643e21e9cad00..41d08091301dd9ebdc771bf38d551aae8e8bb424 100644
--- a/third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp
+++ b/third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp
@@ -345,11 +345,14 @@ int DatabaseAuthorizer::denyBasedOnTableName(const String& tableName) const {
if (!m_securityEnabled)
return SQLAuthAllow;
- // Sadly, normal creates and drops end up affecting sqlite_master in an authorizer callback, so
- // it will be tough to enforce all of the following policies
- //if (equalIgnoringCase(tableName, "sqlite_master") || equalIgnoringCase(tableName, "sqlite_temp_master") ||
- // equalIgnoringCase(tableName, "sqlite_sequence") || equalIgnoringCase(tableName, Database::databaseInfoTableName()))
- // return SQLAuthDeny;
+ // Sadly, normal creates and drops end up affecting sqlite_master in an
+ // authorizer callback, so it will be tough to enforce all of the following
+ // policies:
+ // if (equalIgnoringCase(tableName, "sqlite_master") ||
+ // equalIgnoringCase(tableName, "sqlite_temp_master") ||
+ // equalIgnoringCase(tableName, "sqlite_sequence") ||
+ // equalIgnoringCase(tableName, Database::databaseInfoTableName()))
+ // return SQLAuthDeny;
if (equalIgnoringCase(tableName, m_databaseInfoTableName))
return SQLAuthDeny;
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webdatabase/DatabaseClient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698