Issue 2395373003: M54: Fix printing with XPS printers on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2395373003: M54: Fix printing with XPS printers on Windows. (Closed)

Created:
4 years, 2 months ago by Lei Zhang

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

M54: Fix printing with XPS printers on Windows. Check to see if a given printer is XPS. If so, revert back to non-GDI text printing path. BUG=653257 Review-Url: https://codereview.chromium.org/2392343003 Cr-Commit-Position: refs/heads/master@{#423372} (cherry picked from commit 1f8436ba96d348607317d2d34cb604a9243f0ff0) Committed: https://chromium.googlesource.com/chromium/src/+/ad85552ccdd70ce4945b602abb9caf3fc1b852b0

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -3 lines)			Patch
M	chrome/browser/printing/print_view_manager_base.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	printing/print_settings.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	printing/print_settings.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	printing/print_settings_initializer_win.cc	View	3 chunks	+34 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Lei Zhang

4 years, 2 months ago (2016-10-07 23:47:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ad85552ccdd70ce4945b602abb9caf3fc1b852b0.