Fix printing with XPS printers on Windows.

Fix printing with XPS printers on Windows.

Check to see if a given printer is XPS. If so, revert back to non-GDI
text printing path.

BUG=653257
Committed: https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0
Cr-Commit-Position: refs/heads/master@{#423372}

[Lei Zhang, 2016-10-05 22:55:37]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 22:56:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-10-05 22:56:41]

thestig@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2016-10-05 23:21:40]

lgtm

https://codereview.chromium.org/2392343003/diff/1/printing/print_settings_ini...
File printing/print_settings_initializer_win.cc (right):

https://codereview.chromium.org/2392343003/diff/1/printing/print_settings_ini...
printing/print_settings_initializer_win.cc:20: const int escape = GETTECHNOLOGY;
nit; DWORD since that's what the docs say.

https://msdn.microsoft.com/en-us/library/windows/desktop/dd144931(v=vs.85).aspx
implies you can just call the second one and it'll return 0 though so maybe you
don't need to call it at all?

[Lei Zhang, 2016-10-05 23:37:56]

https://codereview.chromium.org/2392343003/diff/1/printing/print_settings_ini...
File printing/print_settings_initializer_win.cc (right):

https://codereview.chromium.org/2392343003/diff/1/printing/print_settings_ini...
printing/print_settings_initializer_win.cc:20: const int escape = GETTECHNOLOGY;
On 2016/10/05 23:21:40, scottmg wrote:
> nit; DWORD since that's what the docs say.

Done.

>
https://msdn.microsoft.com/en-us/library/windows/desktop/dd144931(v=vs.85).aspx
> implies you can just call the second one and it'll return 0 though so maybe
you
> don't need to call it at all?

I tested with several printers that are known to not support GETTECHNOLOGY and
called ExtEscape with GETTECHNOLOGY anyway.

- Some returned 0
- Some returned 1, and did not appear to write to |buffer|.

It feels like this is getting into undefined territory, so I'll stick with the
QUERYESCSUPPORT check to avoid potentially upsetting some fragile printer
driver.

[Lei Zhang, 2016-10-05 23:38:48]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 23:39:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-10-05 23:41:50]

On 2016/10/05 23:37:56, Lei Zhang wrote:
>
https://codereview.chromium.org/2392343003/diff/1/printing/print_settings_ini...
> File printing/print_settings_initializer_win.cc (right):
> 
>
https://codereview.chromium.org/2392343003/diff/1/printing/print_settings_ini...
> printing/print_settings_initializer_win.cc:20: const int escape =
GETTECHNOLOGY;
> On 2016/10/05 23:21:40, scottmg wrote:
> > nit; DWORD since that's what the docs say.
> 
> Done.
> 
> >
>
https://msdn.microsoft.com/en-us/library/windows/desktop/dd144931(v=vs.85).aspx
> > implies you can just call the second one and it'll return 0 though so maybe
> you
> > don't need to call it at all?
> 
> I tested with several printers that are known to not support GETTECHNOLOGY and
> called ExtEscape with GETTECHNOLOGY anyway.
> 
> - Some returned 0
> - Some returned 1, and did not appear to write to |buffer|.

Maybe memset the whole thing and pass sizeof(buffer)-1 to make sure you have
something to strcmp against then?

> It feels like this is getting into undefined territory, so I'll stick with the
> QUERYESCSUPPORT check to avoid potentially upsetting some fragile printer
> driver.

Oooooookie dokie!

[Lei Zhang, 2016-10-05 23:47:54]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 23:48:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-10-05 23:48:11]

On 2016/10/05 23:41:50, scottmg wrote:
> Maybe memset the whole thing and pass sizeof(buffer)-1 to make sure you have
> something to strcmp against then?

Done, since I have my paranoid hat on.

[commit-bot: I haz the power, 2016-10-06 01:00:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 01:00:29]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-06 01:01:09]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-10-06 01:01:10]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2392343003/#ps40001
(title: "memset, buffer size")

[commit-bot: I haz the power, 2016-10-06 01:02:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 01:09:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-06 01:12:51]

Description was changed from

==========
Fix printing with XPS printers on Windows.

Check to see if a given printer is XPS. If so, revert back to non-GDI
text printing path.

BUG=653257
==========

to

==========
Fix printing with XPS printers on Windows.

Check to see if a given printer is XPS. If so, revert back to non-GDI
text printing path.

BUG=653257

Committed: https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0
Cr-Commit-Position: refs/heads/master@{#423372}
==========

[commit-bot: I haz the power, 2016-10-06 01:12:52]

Patchset 3 (id:??) landed as
https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0
Cr-Commit-Position: refs/heads/master@{#423372}