Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 2392343003: Fix printing with XPS printers on Windows. (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix printing with XPS printers on Windows. Check to see if a given printer is XPS. If so, revert back to non-GDI text printing path. BUG=653257 Committed: https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0 Cr-Commit-Position: refs/heads/master@{#423372}

Patch Set 1 #

Total comments: 2

Patch Set 2 : DWORD #

Patch Set 3 : memset, buffer size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M chrome/browser/printing/print_view_manager_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/print_settings.h View 2 chunks +6 lines, -0 lines 0 comments Download
M printing/print_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/print_settings_initializer_win.cc View 1 2 3 chunks +34 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Lei Zhang
4 years, 2 months ago (2016-10-05 22:56:41 UTC) #4
scottmg
lgtm https://codereview.chromium.org/2392343003/diff/1/printing/print_settings_initializer_win.cc File printing/print_settings_initializer_win.cc (right): https://codereview.chromium.org/2392343003/diff/1/printing/print_settings_initializer_win.cc#newcode20 printing/print_settings_initializer_win.cc:20: const int escape = GETTECHNOLOGY; nit; DWORD since ...
4 years, 2 months ago (2016-10-05 23:21:40 UTC) #5
Lei Zhang
https://codereview.chromium.org/2392343003/diff/1/printing/print_settings_initializer_win.cc File printing/print_settings_initializer_win.cc (right): https://codereview.chromium.org/2392343003/diff/1/printing/print_settings_initializer_win.cc#newcode20 printing/print_settings_initializer_win.cc:20: const int escape = GETTECHNOLOGY; On 2016/10/05 23:21:40, scottmg ...
4 years, 2 months ago (2016-10-05 23:37:56 UTC) #6
scottmg
On 2016/10/05 23:37:56, Lei Zhang wrote: > https://codereview.chromium.org/2392343003/diff/1/printing/print_settings_initializer_win.cc > File printing/print_settings_initializer_win.cc (right): > > https://codereview.chromium.org/2392343003/diff/1/printing/print_settings_initializer_win.cc#newcode20 ...
4 years, 2 months ago (2016-10-05 23:41:50 UTC) #9
Lei Zhang
On 2016/10/05 23:41:50, scottmg wrote: > Maybe memset the whole thing and pass sizeof(buffer)-1 to ...
4 years, 2 months ago (2016-10-05 23:48:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392343003/40001
4 years, 2 months ago (2016-10-06 01:02:38 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-06 01:09:45 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 01:12:52 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0
Cr-Commit-Position: refs/heads/master@{#423372}

Powered by Google App Engine
This is Rietveld 408576698