Revert of Make ResourceFetcher return Resources with LoadError instead of nullptrs.

Revert of Make ResourceFetcher return Resources with LoadError instead of nullptrs. (patchset #8 id:160001 of https://codereview.chromium.org/2231523002/ )

Reason for revert:
Reverting since it is causing flakiness on the blink bots. Latest flake:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/7628

unexpected_failures:
http/tests/security/contentSecurityPolicy/nonces/import-enforce-blocked.php

Original issue's description:
> Make ResourceFetcher return Resources with LoadError instead of nullptrs.
> 
> Before this change, when a request was immediately blocked by access checks,
> ResourceFetcher::requestResource() would return a nullptr, while returning a
> Resource instance with a LoadError set if the request was blocked only after
> following one or more redirects. This resulted in various resource types
> failing in inconsistent ways in the two cases.
> 
> This CL makes this behavior consistent by making requestResource() always
> return a Resource instance with a LoadError. This allows for cleaner and more
> consistent handling of errors in ResourceClients, as wells as more flexibility
> should the client choose to distinguish the underlying causes of errors. Due
> to the infrequency of requests failing access checks during normal use, the
> performance impact should be negligible.
> 
> BUG=616234
> 
> Committed: https://crrev.com/fd02740210e0152c94bd4c34a1e355280421730d
> Cr-Commit-Position: refs/heads/master@{#423358}

TBR=japhet@chromium.org,alexmos@chromium.org,engedy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616234

[nasko, 2016-10-06 22:16:07]

The CQ bit was checked by nasko@chromium.org

[nasko, 2016-10-06 22:16:08]

Created Revert of Make ResourceFetcher return Resources with LoadError instead
of nullptrs.

[commit-bot: I haz the power, 2016-10-06 22:16:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 22:17:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 22:17:29]

Failed to apply patch for
third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html:
While running git apply --index -3 -p1;
  error:
third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html:
does not exist in index

Patch:      
third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html
Index:
third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html
diff --git
a/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html
b/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html
index
6b441c29313069069f3a646b4a1d4ff848206f77..16eccc1833297e0dd18a8efdd5da3635a85a6b93
100644
---
a/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html
+++
b/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html
@@ -19,32 +19,28 @@
         document.addEventListener("securitypolicyviolation", function (e) {
           blocked[e.lineNumber] = true;
         });
-    </script>
-    <!-- Need to individually wrap test cases in script blocks. Violation
reports triggered by document.write() calls while the parser is waiting on
blocking scipts are missing line numbers. See: https://crbug.com/649085. -->
-    <script nonce="abcdefg">
+
         async_test(function (t) {
           document.write("<scr" + "ipt src='" + generateURL("write") +
"'></scr" + "ipt>");
           setTimeout(t.step_func_done(function () {
             assert_equals(loaded[generateURL("write")], undefined);
-            assert_true(blocked[26]);
+            assert_true(blocked[24]);
           }), 1);
         }, "Script injected via 'document.write' is not allowed with
'strict-dynamic', even if whitelisted.");
-    </script>
-    <script nonce="abcdefg">
+
         async_test(function (t) {
           document.write("<scr" + "ipt defer src='" +
generateURL("write-defer") + "'></scr" + "ipt>");
           setTimeout(t.step_func_done(function () {
             assert_equals(loaded[generateURL("write-defer")], undefined);
-            assert_true(blocked[35]);
+            assert_true(blocked[32]);
           }), 1);
         }, "Deferred script injected via 'document.write' is not allowed with
'strict-dynamic', even if whitelisted.");
-    </script>
-    <script nonce="abcdefg">
+
         async_test(function (t) {
           document.write("<scr" + "ipt async src='" +
generateURL("write-async") + "'></scr" + "ipt>");
           setTimeout(t.step_func_done(function () {
             assert_equals(loaded[generateURL("write-async")], undefined);
-            assert_true(blocked[44]);
+            assert_true(blocked[40]);
           }), 1);
         }, "Async script injected via 'document.write' is not allowed with
'strict-dynamic', even if whitelisted.");
     </script>

[engedy, 2016-10-06 22:20:45]

Looks like the file in question was modified by this CL:
https://codereview.chromium.org/2401573003.

[engedy, 2016-10-12 08:48:28]

Description was changed from

==========
Revert of Make ResourceFetcher return Resources with LoadError instead of
nullptrs. (patchset #8 id:160001 of https://codereview.chromium.org/2231523002/
)

Reason for revert:
Reverting since it is causing flakiness on the blink bots. Latest flake:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...

unexpected_failures:
http/tests/security/contentSecurityPolicy/nonces/import-enforce-blocked.php

Original issue's description:
> Make ResourceFetcher return Resources with LoadError instead of nullptrs.
> 
> Before this change, when a request was immediately blocked by access checks,
> ResourceFetcher::requestResource() would return a nullptr, while returning a
> Resource instance with a LoadError set if the request was blocked only after
> following one or more redirects. This resulted in various resource types
> failing in inconsistent ways in the two cases.
> 
> This CL makes this behavior consistent by making requestResource() always
> return a Resource instance with a LoadError. This allows for cleaner and more
> consistent handling of errors in ResourceClients, as wells as more flexibility
> should the client choose to distinguish the underlying causes of errors. Due
> to the infrequency of requests failing access checks during normal use, the
> performance impact should be negligible.
> 
> BUG=616234
> 
> Committed: https://crrev.com/fd02740210e0152c94bd4c34a1e355280421730d
> Cr-Commit-Position: refs/heads/master@{#423358}

TBR=japhet@chromium.org,alexmos@chromium.org,engedy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616234
==========

to

==========
Revert of Make ResourceFetcher return Resources with LoadError instead of
nullptrs. (patchset #8 id:160001 of https://codereview.chromium.org/2231523002/
)

Reason for revert:
Reverting since it is causing flakiness on the blink bots. Latest flake:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...

unexpected_failures:
http/tests/security/contentSecurityPolicy/nonces/import-enforce-blocked.php

Original issue's description:
> Make ResourceFetcher return Resources with LoadError instead of nullptrs.
> 
> Before this change, when a request was immediately blocked by access checks,
> ResourceFetcher::requestResource() would return a nullptr, while returning a
> Resource instance with a LoadError set if the request was blocked only after
> following one or more redirects. This resulted in various resource types
> failing in inconsistent ways in the two cases.
> 
> This CL makes this behavior consistent by making requestResource() always
> return a Resource instance with a LoadError. This allows for cleaner and more
> consistent handling of errors in ResourceClients, as wells as more flexibility
> should the client choose to distinguish the underlying causes of errors. Due
> to the infrequency of requests failing access checks during normal use, the
> performance impact should be negligible.
> 
> BUG=616234
> 
> Committed: https://crrev.com/fd02740210e0152c94bd4c34a1e355280421730d
> Cr-Commit-Position: refs/heads/master@{#423358}

TBR=japhet@chromium.org,alexmos@chromium.org,engedy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616234
==========

[engedy, 2016-10-12 08:50:33]

Another CL was created manually to perform the revert, due to conflicts:
https://codereview.chromium.org/2399243002.

[engedy, 2016-10-12 08:51:54]

For clarity, I haven't made any changes now, just documenting what happened 5
days ago.