Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6186)

Unified Diff: chrome/browser/translate/chrome_translate_client.h

Issue 2395253002: Send TranslateEventProtos to UMA. (Closed)
Patch Set: nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/chrome_translate_client.h
diff --git a/chrome/browser/translate/chrome_translate_client.h b/chrome/browser/translate/chrome_translate_client.h
index cf027569a97d7195652d9b259ccc2421e00e7ab2..4a481706742278d04a944843b9eb596b91a2151e 100644
--- a/chrome/browser/translate/chrome_translate_client.h
+++ b/chrome/browser/translate/chrome_translate_client.h
@@ -36,6 +36,10 @@ class TranslatePrefs;
class TranslateManager;
} // namespace translate
+namespace metrics {
+class TranslateEventProto;
+} // namespace metrics
+
class ChromeTranslateClient
: public translate::TranslateClient,
public translate::ContentTranslateDriver::Observer,
@@ -83,6 +87,11 @@ class ChromeTranslateClient
// destroyed.
content::WebContents* GetWebContents();
+ // Record a TranslateEventProto. If the metrics provider is not accessible,
+ // returns false.
+ bool RecordTranslateEvent(
Roger McFarlane (Chromium) 2016/10/12 18:18:28 this entry point isn't needed. The TranslateManage
hamelphi 2016/10/12 21:06:09 Done.
+ const metrics::TranslateEventProto& translate_event);
+
// TranslateClient implementation.
translate::TranslateDriver* GetTranslateDriver() override;
PrefService* GetPrefs() override;

Powered by Google App Engine
This is Rietveld 408576698