Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: chrome/browser/translate/chrome_translate_client.cc

Issue 2395253002: Send TranslateEventProtos to UMA. (Closed)
Patch Set: nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/chrome_translate_client.cc
diff --git a/chrome/browser/translate/chrome_translate_client.cc b/chrome/browser/translate/chrome_translate_client.cc
index 06ce2bbbcd236307ca099d12faf0e7064c05534a..df149dbf98e649d3bbccf16941f4b5b45e09f572 100644
--- a/chrome/browser/translate/chrome_translate_client.cc
+++ b/chrome/browser/translate/chrome_translate_client.cc
@@ -35,6 +35,7 @@
#include "components/translate/core/browser/translate_infobar_delegate.h"
#include "components/translate/core/browser/translate_manager.h"
#include "components/translate/core/browser/translate_prefs.h"
+#include "components/translate/core/browser/translate_ranker.h"
#include "components/translate/core/common/language_detection_details.h"
#include "components/variations/service/variations_service.h"
#include "content/public/browser/notification_service.h"
@@ -167,6 +168,21 @@ translate::TranslateManager* ChromeTranslateClient::GetTranslateManager() {
return translate_manager_.get();
}
+// TODO(rogerm): This code can be moved into TranslateManager.
Roger McFarlane (Chromium) 2016/10/12 18:18:28 This can be removed. TranslateManager is is the in
hamelphi 2016/10/12 21:06:09 Agreed. Removed.
+bool ChromeTranslateClient::RecordTranslateEvent(
+ const metrics::TranslateEventProto& translate_event) {
+ if (translate::TranslateRanker::IsLoggingEnabled()) {
+ translate::TranslateRanker* translate_ranker =
+ translate::TranslateRanker::GetInstance();
+ if (translate_ranker != nullptr) {
+ translate_ranker->RecordTranslateEvent(translate_event);
+ return true;
+ }
+ }
+ return false;
+}
+
+
void ChromeTranslateClient::ShowTranslateUI(
translate::TranslateStep step,
const std::string& source_language,

Powered by Google App Engine
This is Rietveld 408576698