[Autofill] Log count histogram for the number of server cards

[Autofill] Log count histogram for the number of server cards

BUG=653636
TEST=AutofillMetrics

Committed: https://crrev.com/2af1bc9bc29520e5b3893b8c31d008d1b384b296
Cr-Commit-Position: refs/heads/master@{#424053}

[Mathieu, 2016-10-06 18:54:31]

mathp@chromium.org changed reviewers:
+ rkaplow@chromium.org, sebsg@chromium.org

[Mathieu, 2016-10-06 18:54:31]

Hi Seb, PTAL at autofill*
Hi Rob, PTAL at histograms.xml

[sebsg, 2016-10-07 13:34:25]

lgtm

[rkaplow, 2016-10-07 17:33:49]

lgtm

https://codereview.chromium.org/2395243002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_metrics.cc (right):

https://codereview.chromium.org/2395243002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_metrics.cc:535:
UMA_HISTOGRAM_COUNTS("Autofill.StoredServerCreditCardCount.Masked",
nit, we're recommending an explicit max now. see histogram_macros.h for details.

COUNTS is the same as HISTOGRAM_COUNTS_1M FWIW if you want to keep this up to
1M. I'm guessing something like 1000 or 10000 is more appropriate

https://codereview.chromium.org/2395243002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2395243002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:3496: +<histogram
name="Autofill.StoredServerCreditCardCount">
should still have a unit, unit="cards" or something

[Mathieu, 2016-10-08 01:36:06]

Thanks

https://codereview.chromium.org/2395243002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_metrics.cc (right):

https://codereview.chromium.org/2395243002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_metrics.cc:535:
UMA_HISTOGRAM_COUNTS("Autofill.StoredServerCreditCardCount.Masked",
On 2016/10/07 17:33:49, rkaplow wrote:
> nit, we're recommending an explicit max now. see histogram_macros.h for
details.
> 
> COUNTS is the same as HISTOGRAM_COUNTS_1M FWIW if you want to keep this up to
> 1M. I'm guessing something like 1000 or 10000 is more appropriate

Done.

https://codereview.chromium.org/2395243002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2395243002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:3496: +<histogram
name="Autofill.StoredServerCreditCardCount">
On 2016/10/07 17:33:49, rkaplow wrote:
> should still have a unit, unit="cards" or something

Done.

[Mathieu, 2016-10-08 01:36:31]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-10-08 01:36:32]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org,
rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2395243002/#ps20001
(title: "addressed nits")

[commit-bot: I haz the power, 2016-10-08 01:36:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 03:03:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-08 03:05:38]

Description was changed from

==========
[Autofill] Log count histogram for the number of server cards

BUG=653636
TEST=AutofillMetrics
==========

to

==========
[Autofill] Log count histogram for the number of server cards

BUG=653636
TEST=AutofillMetrics

Committed: https://crrev.com/2af1bc9bc29520e5b3893b8c31d008d1b384b296
Cr-Commit-Position: refs/heads/master@{#424053}
==========

[commit-bot: I haz the power, 2016-10-08 03:05:39]

Patchset 2 (id:??) landed as
https://crrev.com/2af1bc9bc29520e5b3893b8c31d008d1b384b296
Cr-Commit-Position: refs/heads/master@{#424053}