Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: components/autofill/core/browser/personal_data_manager.h

Issue 2395243002: [Autofill] Log count histogram for the number of server cards (Closed)
Patch Set: addressed nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/personal_data_manager.h
diff --git a/components/autofill/core/browser/personal_data_manager.h b/components/autofill/core/browser/personal_data_manager.h
index e0a86900c278ded9167a9176179322c6c8556b36..ac558756e007800e12cd49b3d37fe4d8cd30b74c 100644
--- a/components/autofill/core/browser/personal_data_manager.h
+++ b/components/autofill/core/browser/personal_data_manager.h
@@ -355,6 +355,11 @@ class PersonalDataManager : public KeyedService,
// credit cards the user has. On subsequent calls, does nothing.
void LogLocalCreditCardCount() const;
+ // The first time this is called, logs an UMA metric for the number of server
+ // credit cards the user has (both masked and unmasked). On subsequent calls,
+ // does nothing.
+ void LogServerCreditCardCounts() const;
+
// Returns the value of the AutofillEnabled pref.
virtual bool IsAutofillEnabled() const;
@@ -501,7 +506,11 @@ class PersonalDataManager : public KeyedService,
// Whether we have already logged the number of local credit cards this
// session.
- mutable bool has_logged_credit_card_count_;
+ mutable bool has_logged_local_credit_card_count_;
+
+ // Whether we have already logged the number of server credit cards this
+ // session.
+ mutable bool has_logged_server_credit_card_counts_;
// An observer to listen for changes to prefs::kAutofillEnabled.
std::unique_ptr<BooleanPrefMember> enabled_pref_;

Powered by Google App Engine
This is Rietveld 408576698