git cl try-results: refactor Rietveld + add tests.

git cl try-results: refactor Rietveld + add tests.

R=emso@chromium.org,phajdan.jr@chromium.org
BUG=599931
TEST=new teste + local end-to-end

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/221ab25f46ce6469c7b00e080751428c94316552

[tandrii(chromium), 2016-10-06 13:16:58]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 13:17:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2016-10-06 13:18:20]

Description was changed from

==========
git cl try-results: refactor Rietveld + add tests.

R=emso@chromium.org,phajdan.jr@chromium.org
BUG=
==========

to

==========
git cl try-results: refactor Rietveld + add tests.

R=emso@chromium.org,phajdan.jr@chromium.org
BUG=599931
==========

[commit-bot: I haz the power, 2016-10-06 13:19:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 13:19:50]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-10-06 13:21:01]

Description was changed from

==========
git cl try-results: refactor Rietveld + add tests.

R=emso@chromium.org,phajdan.jr@chromium.org
BUG=599931
==========

to

==========
git cl try-results: refactor Rietveld + add tests.

R=emso@chromium.org,phajdan.jr@chromium.org
BUG=599931
TEST=new teste + local end-to-end
==========

[tandrii(chromium), 2016-10-06 13:21:11]

PTAL

https://codereview.chromium.org/2395113002/diff/1/git_cl.py
File git_cl.py (left):

https://codereview.chromium.org/2395113002/diff/1/git_cl.py#oldcode4853
git_cl.py:4853: except Exception as e:
there is no value in this, stack trace is printed anyway, and a nicer one. And
this chunk also makes testing hard because stack is printed to stdout instead of
stderr.

https://codereview.chromium.org/2395113002/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (left):

https://codereview.chromium.org/2395113002/diff/1/tests/git_cl_test.py#oldcod...
tests/git_cl_test.py:1858: def test_write_try_results_json(self):
this isn't changed, just moved + builds below made a constant.

https://codereview.chromium.org/2395113002/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/2395113002/diff/1/tests/git_cl_test.py#newcod...
tests/git_cl_test.py:1949: def test_write_try_results_json(self):
same as before.

https://codereview.chromium.org/2395113002/diff/1/tests/git_cl_test.py#newcod...
tests/git_cl_test.py:1973: def _setup_fetch_try_jobs_rietveld(self,
*request_results):
this and below is actually new code -- adding test coverage.

[Paweł Hajdan Jr., 2016-10-06 15:02:33]

LGTM

[tandrii(chromium), 2016-10-06 15:08:46]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-10-06 15:08:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 15:12:06]

Description was changed from

==========
git cl try-results: refactor Rietveld + add tests.

R=emso@chromium.org,phajdan.jr@chromium.org
BUG=599931
TEST=new teste + local end-to-end
==========

to

==========
git cl try-results: refactor Rietveld + add tests.

R=emso@chromium.org,phajdan.jr@chromium.org
BUG=599931
TEST=new teste + local end-to-end

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/221ab25f46ce64...
==========

[commit-bot: I haz the power, 2016-10-06 15:12:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/221ab25f46ce64...