git cl try-results for Gerrit.

git cl try-results regression tests for Gerrit.

The flow looks like this:

  $ git cl status
  Branches associated with reviews:
    gerrit-4483 : https://chromium-review.googlesource.com/381231 (waiting)

  $ git cl try-results
  Warning: Codereview server has newer patchsets (2) than most recent
  upload from local checkout (None). Did a previous upload fail?
  By default, git cl try uses latest patchset from codereview,
  continuing using such patchset 2.

  Warning: Some results might be missing because You are not logged in.
  Please login first by running:
    depot-tools-auth login chromium-review.googlesource.com
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
  Total: 2 try jobs

  $ depot-tools-auth login chromium-review.googlesource.com
   <<<auth in my browser>>>

  Logged in to chromium-review.googlesource.com as <some@email.com>;

	To login with a different email run:
		depot-tools-auth login chromium-review.googlesource.com
	To logout and purge the authentication token run:
		depot-tools-auth logout chromium-review.googlesource.com

  $ git config branch.gerrit-4483.gerritpatchset 2
  $ git cl try-results
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
    Infra Mac Tester              https://luci-milo.appspot.com/swarming/...
  Total: 3 try jobs


R=sergiyb@chromium.org,emso@chromium.org
BUG=599931
TEST=new unittests + end-to-end local.

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/45b2a5891aa4a281e8c1bcf74d3e9f6dd9a61bfc

[tandrii(chromium), 2016-10-06 18:02:48]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 18:02:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2016-10-06 18:04:44]

tandrii@chromium.org changed reviewers:
+ nodir@chromium.org, vadimsh@chromium.org

[tandrii(chromium), 2016-10-06 18:04:45]

+nodir@ +vadimsh@

I'm essentially asking users to do (see CL description)
$ depot-tools-auth login chromium-review.googlesource.com

and then use that to auth against buildbucket. This is because getting this
token from Gerrit is PITA. WDYT?

[commit-bot: I haz the power, 2016-10-06 18:06:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 18:06:22]

Dry run: This issue passed the CQ dry run.

[nodir, 2016-10-07 04:15:10]

I'll look into this tomorrow, had a busy day today. Vadim is OOO till next
week
On Thu, Oct 6, 2016 at 11:04 AM <tandrii@chromium.org> wrote:

> +nodir@ +vadimsh@
>
> I'm essentially asking users to do (see CL description)
> $ depot-tools-auth login chromium-review.googlesource.com
>
> and then use that to auth against buildbucket. This is because getting this
> token from Gerrit is PITA. WDYT?
>
> https://codereview.chromium.org/2392463009/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[emso, 2016-10-07 06:56:28]

lgtm

It doesn't seem like you are adding 'git cl try-results' in this change (despite
the title). Is there anything missing?

https://codereview.chromium.org/2392463009/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2392463009/diff/1/git_cl.py#newcode4863
git_cl.py:4863: 'continuing using such patchset %s.\n' %
How about "continuing to use patchset" instead?

[tandrii(chromium), 2016-10-07 12:25:39]

On 2016/10/07 06:56:28, emso wrote:
> lgtm
> 
> It doesn't seem like you are adding 'git cl try-results' in this change
(despite
> the title). Is there anything missing?
Well, strictly speaking, previous refactoring already made existing "git cl
try-results" code work with Gerrit.
This change merely codified that by adding regression tests, so that it stays
this way.

[tandrii(chromium), 2016-10-07 12:26:48]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[tandrii(chromium), 2016-10-07 12:26:51]

https://codereview.chromium.org/2392463009/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2392463009/diff/1/git_cl.py#newcode4863
git_cl.py:4863: 'continuing using such patchset %s.\n' %
On 2016/10/07 06:56:27, emso wrote:
> How about "continuing to use patchset" instead?

good idea!

[commit-bot: I haz the power, 2016-10-07 12:26:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 12:30:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 12:30:08]

Dry run: This issue passed the CQ dry run.

[Sergiy Byelozyorov, 2016-10-07 15:36:13]

https://codereview.chromium.org/2392463009/diff/20001/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/2392463009/diff/20001/tests/git_cl_test.py#ne...
tests/git_cl_test.py:1987: ((['git', 'config',
'branch.feature.rietveldissue'],), '1'),
shouldn't 

((['git', 'config', 'branch.feature.gerritissue'],), CERR1),

be added here?

https://codereview.chromium.org/2392463009/diff/20001/tests/git_cl_test.py#ne...
tests/git_cl_test.py:2003: 'Warning: Some results might be missing')
why was this logic changed? didn't it work from before?

[tandrii(chromium), 2016-10-07 15:38:47]

https://codereview.chromium.org/2392463009/diff/20001/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/2392463009/diff/20001/tests/git_cl_test.py#ne...
tests/git_cl_test.py:1987: ((['git', 'config',
'branch.feature.rietveldissue'],), '1'),
On 2016/10/07 15:36:13, Sergiy Byelozyorov wrote:
> shouldn't 
> 
> ((['git', 'config', 'branch.feature.gerritissue'],), CERR1),
> 
> be added here?

No, because it's expectation :)
Well, actually if Rietveld issue is found, git cl doesn't look for Gerrit
issues.

https://codereview.chromium.org/2392463009/diff/20001/tests/git_cl_test.py#ne...
tests/git_cl_test.py:2003: 'Warning: Some results might be missing')
On 2016/10/07 15:36:13, Sergiy Byelozyorov wrote:
> why was this logic changed? didn't it work from before?

I changed the test to have better coverage. Actual logic wasn't changed.

[Sergiy Byelozyorov, 2016-10-07 15:39:31]

lgtm

https://codereview.chromium.org/2392463009/diff/20001/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/2392463009/diff/20001/tests/git_cl_test.py#ne...
tests/git_cl_test.py:1987: ((['git', 'config',
'branch.feature.rietveldissue'],), '1'),
On 2016/10/07 15:38:47, tandrii(chromium) wrote:
> On 2016/10/07 15:36:13, Sergiy Byelozyorov wrote:
> > shouldn't 
> > 
> > ((['git', 'config', 'branch.feature.gerritissue'],), CERR1),
> > 
> > be added here?
> 
> No, because it's expectation :)
> Well, actually if Rietveld issue is found, git cl doesn't look for Gerrit
> issues.

Acknowledged.

https://codereview.chromium.org/2392463009/diff/20001/tests/git_cl_test.py#ne...
tests/git_cl_test.py:2003: 'Warning: Some results might be missing')
On 2016/10/07 15:38:47, tandrii(chromium) wrote:
> On 2016/10/07 15:36:13, Sergiy Byelozyorov wrote:
> > why was this logic changed? didn't it work from before?
> 
> I changed the test to have better coverage. Actual logic wasn't changed.

Acknowledged.

[nodir, 2016-10-07 17:09:05]

why does `git cl try-results` in the CL description says 5 total build and
displays only 3?

[nodir, 2016-10-07 17:11:12]

I think CL description is inaccurate. It reads as "this CL adds Gerrit support
to try-resulst", but in fact it improves a warning message
otherwise lgtm

[tandrii(chromium), 2016-10-09 10:52:06]

Description was changed from

==========
git cl try-results for Gerrit.

The flow looks like this:

  $ git cl status
  Branches associated with reviews:
    gerrit-4483 : https://chromium-review.googlesource.com/381231 (waiting)

  $ git cl try-results
  Warning: Codereview server has newer patchsets (2) than most recent
  upload from local checkout (None). Did a previous upload fail?
  By default, git cl try uses latest patchset from codereview,
  continuing using such patchset 2.

  Warning: Some results might be missing because You are not logged in.
  Please login first by running:
    depot-tools-auth login chromium-review.googlesource.com
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
  Total: 5 try jobs

  $ depot-tools-auth login chromium-review.googlesource.com
   <<<auth in my browser>>>

  Logged in to chromium-review.googlesource.com as <some@email.com>

	To login with a different email run:
		depot-tools-auth login chromium-review.googlesource.com
	To logout and purge the authentication token run:
		depot-tools-auth logout chromium-review.googlesource.com

  $ git config branch.gerrit-4483.gerritpatchset 2
  $ git cl try-results
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
    Infra Mac Tester              https://luci-milo.appspot.com/swarming/...
  Total: 5 try jobs


R=sergiyb@chromium.org,emso@chromium.org
BUG=599931
TEST=new unittests + end-to-end local.
==========

to

==========
git cl try-results regression tests for Gerrit.

The flow looks like this:

  $ git cl status
  Branches associated with reviews:
    gerrit-4483 : https://chromium-review.googlesource.com/381231 (waiting)

  $ git cl try-results
  Warning: Codereview server has newer patchsets (2) than most recent
  upload from local checkout (None). Did a previous upload fail?
  By default, git cl try uses latest patchset from codereview,
  continuing using such patchset 2.

  Warning: Some results might be missing because You are not logged in.
  Please login first by running:
    depot-tools-auth login chromium-review.googlesource.com
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
  Total: 2 try jobs

  $ depot-tools-auth login chromium-review.googlesource.com
   <<<auth in my browser>>>

  Logged in to chromium-review.googlesource.com as <some@email.com>

	To login with a different email run:
		depot-tools-auth login chromium-review.googlesource.com
	To logout and purge the authentication token run:
		depot-tools-auth logout chromium-review.googlesource.com

  $ git config branch.gerrit-4483.gerritpatchset 2
  $ git cl try-results
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
    Infra Mac Tester              https://luci-milo.appspot.com/swarming/...
  Total: 3 try jobs


R=sergiyb@chromium.org,emso@chromium.org
BUG=599931
TEST=new unittests + end-to-end local.
==========

[tandrii(chromium), 2016-10-09 10:52:25]

Description updated, since it confused 3 reviewers

[Vadim Sh., 2016-10-10 21:09:04]

lgtm

In theory it might be possible to reuse the token from .gitcookies/.netrc when
talking to Buildbucket. Except it doesn't have email OAuth scopes :(

(which is required when using OAuth from GAE).

It might be possible to convince Gerrit team to start making tokens with email
scope (in addition to Gerrit scope). But it will require all users to regenerate
their "git passwords" :(

So ugly "depot-tools-auth login" is probably more practical in the end.

[tandrii(chromium), 2016-10-11 10:10:46]

On 2016/10/10 21:09:04, Vadim Sh. wrote:
> lgtm
> 
> In theory it might be possible to reuse the token from .gitcookies/.netrc when
> talking to Buildbucket. Except it doesn't have email OAuth scopes :(
> 
> (which is required when using OAuth from GAE).
> 
> It might be possible to convince Gerrit team to start making tokens with email
> scope (in addition to Gerrit scope). But it will require all users to
regenerate
> their "git passwords" :(
Briefly discussed on internal bug, decided against it for now, exactly because
of 
> So ugly "depot-tools-auth login" is probably more practical in the end.
*this*

[tandrii(chromium), 2016-10-11 10:10:54]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-10-11 10:10:54]

The patchset sent to the CQ was uploaded after l-g-t-m from emso@chromium.org
Link to the patchset: https://codereview.chromium.org/2392463009/#ps20001
(title: "Better message.")

[commit-bot: I haz the power, 2016-10-11 10:11:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 10:14:19]

Description was changed from

==========
git cl try-results regression tests for Gerrit.

The flow looks like this:

  $ git cl status
  Branches associated with reviews:
    gerrit-4483 : https://chromium-review.googlesource.com/381231 (waiting)

  $ git cl try-results
  Warning: Codereview server has newer patchsets (2) than most recent
  upload from local checkout (None). Did a previous upload fail?
  By default, git cl try uses latest patchset from codereview,
  continuing using such patchset 2.

  Warning: Some results might be missing because You are not logged in.
  Please login first by running:
    depot-tools-auth login chromium-review.googlesource.com
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
  Total: 2 try jobs

  $ depot-tools-auth login chromium-review.googlesource.com
   <<<auth in my browser>>>

  Logged in to chromium-review.googlesource.com as <some@email.com>

	To login with a different email run:
		depot-tools-auth login chromium-review.googlesource.com
	To logout and purge the authentication token run:
		depot-tools-auth logout chromium-review.googlesource.com

  $ git config branch.gerrit-4483.gerritpatchset 2
  $ git cl try-results
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
    Infra Mac Tester              https://luci-milo.appspot.com/swarming/...
  Total: 3 try jobs


R=sergiyb@chromium.org,emso@chromium.org
BUG=599931
TEST=new unittests + end-to-end local.
==========

to

==========
git cl try-results regression tests for Gerrit.

The flow looks like this:

  $ git cl status
  Branches associated with reviews:
    gerrit-4483 : https://chromium-review.googlesource.com/381231 (waiting)

  $ git cl try-results
  Warning: Codereview server has newer patchsets (2) than most recent
  upload from local checkout (None). Did a previous upload fail?
  By default, git cl try uses latest patchset from codereview,
  continuing using such patchset 2.

  Warning: Some results might be missing because You are not logged in.
  Please login first by running:
    depot-tools-auth login chromium-review.googlesource.com
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
  Total: 2 try jobs

  $ depot-tools-auth login chromium-review.googlesource.com
   <<<auth in my browser>>>

  Logged in to chromium-review.googlesource.com as <some@email.com>

	To login with a different email run:
		depot-tools-auth login chromium-review.googlesource.com
	To logout and purge the authentication token run:
		depot-tools-auth logout chromium-review.googlesource.com

  $ git config branch.gerrit-4483.gerritpatchset 2
  $ git cl try-results
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
    Infra Mac Tester              https://luci-milo.appspot.com/swarming/...
  Total: 3 try jobs


R=sergiyb@chromium.org,emso@chromium.org
BUG=599931
TEST=new unittests + end-to-end local.

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/45b2a5891aa4a2...
==========

[commit-bot: I haz the power, 2016-10-11 10:14:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/45b2a5891aa4a2...