Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2395013002: Remove safesync support from gclient[_scm].py (Closed)

Created:
4 years, 2 months ago by agable
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Updated patchset dependency #

Patch Set 3 : Updated patchset dependency #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -87 lines) Patch
M fetch_configs/breakpad.py View 1 chunk +0 lines, -1 line 0 comments Download
M fetch_configs/chromium.py View 1 chunk +0 lines, -1 line 0 comments Download
M fetch_configs/dart.py View 1 chunk +0 lines, -1 line 0 comments Download
M fetch_configs/dartino.py View 1 chunk +0 lines, -1 line 0 comments Download
M fetch_configs/dartium.py View 1 chunk +0 lines, -1 line 0 comments Download
M fetch_configs/gyp.py View 1 chunk +0 lines, -1 line 0 comments Download
M fetch_configs/ios_internal.py View 1 chunk +0 lines, -1 line 0 comments Download
M fetch_configs/mojo.py View 1 chunk +0 lines, -1 line 0 comments Download
M fetch_configs/nacl.py View 1 chunk +0 lines, -1 line 0 comments Download
M fetch_configs/naclports.py View 1 chunk +0 lines, -1 line 0 comments Download
M fetch_configs/v8.py View 1 chunk +0 lines, -1 line 0 comments Download
M fetch_configs/webrtc.py View 1 chunk +0 lines, -1 line 0 comments Download
M gclient.py View 1 2 3 17 chunks +11 lines, -49 lines 0 comments Download
M gclient_scm.py View 1 2 3 2 chunks +2 lines, -11 lines 0 comments Download
M recipe_modules/gclient/api.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/gclient_smoketest.py View 1 2 7 chunks +1 line, -7 lines 0 comments Download
M tests/gclient_test.py View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
agable
4 years, 2 months ago (2016-10-06 00:26:38 UTC) #1
Dirk Pranke
Isn't this still needed for the LKGR builders?
4 years, 2 months ago (2016-10-06 17:45:37 UTC) #2
agable
On 2016/10/06 at 17:45:37, dpranke wrote: > Isn't this still needed for the LKGR builders? ...
4 years, 2 months ago (2016-10-06 18:02:51 UTC) #3
Dirk Pranke
On 2016/10/06 18:02:51, agable wrote: > On 2016/10/06 at 17:45:37, dpranke wrote: > > Isn't ...
4 years, 2 months ago (2016-10-06 18:14:08 UTC) #4
Dirk Pranke
On 2016/10/06 18:14:08, Dirk Pranke (slow) wrote: > On 2016/10/06 18:02:51, agable wrote: > > ...
4 years, 2 months ago (2016-10-06 18:14:30 UTC) #5
Dirk Pranke
lgtm otherwise.
4 years, 2 months ago (2016-10-06 18:15:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395013002/60001
4 years, 1 month ago (2016-11-15 22:26:32 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 22:30:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/a98a6cd47d1325...

Powered by Google App Engine
This is Rietveld 408576698