Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: gclient_scm.py

Issue 2395013002: Remove safesync support from gclient[_scm].py (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient.py ('k') | recipe_modules/gclient/api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_scm.py
diff --git a/gclient_scm.py b/gclient_scm.py
index 4a4e6015461582fbf28a1034f63e66aba1e26770..e64754ce7bf5978845bf34462b71f1ff9675fc63 100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -777,12 +777,7 @@ class GitWrapper(SCMWrapper):
sha1 = None
if not os.path.isdir(self.checkout_path):
raise NoUsableRevError(
- ( 'We could not find a valid hash for safesync_url response "%s".\n'
- 'Safesync URLs with a git checkout currently require the repo to\n'
- 'be cloned without a safesync_url before adding the safesync_url.\n'
- 'For more info, see: '
- 'http://code.google.com/p/chromium/wiki/UsingNewGit'
- '#Initial_checkout' ) % rev)
+ 'This is not a git repo, so we cannot get a usable rev.')
if scm.GIT.IsValidRevision(cwd=self.checkout_path, rev=rev):
sha1 = rev
@@ -795,11 +790,7 @@ class GitWrapper(SCMWrapper):
if not sha1:
raise NoUsableRevError(
- ('We could not find a valid hash for safesync_url response "%s".\n'
- 'Please ensure that your safesync_url provides git sha1 hashes.\n'
- 'For more info, see:\n'
- 'http://code.google.com/p/chromium/wiki/UsingNewGit#Initial_checkout'
- ) % rev)
+ 'Hash %s does not appear to be a valid hash in this repo.' % rev)
return sha1
« no previous file with comments | « gclient.py ('k') | recipe_modules/gclient/api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698