ChannelSplitterNode channelCount and mode are constant

ChannelSplitterNode channelCount and mode are constant.

The channelCount for a ChannelSplitterNode is now set to the number of
outputs and cannot be changed.  The channelCountMode is also fixed to
"explicit".

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/wavuM3cciPc/1Df3Hrr-CAAJ
Feature: https://www.chromestatus.com/feature/4701085050601472

BUG=653234
TEST=constructor/channelsplitter.html updated

Committed: https://crrev.com/efb11f5a890fd4a793dbf8383fb8b529ddf39898
Cr-Commit-Position: refs/heads/master@{#426006}

[Raymond Toy, 2016-10-05 20:50:23]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 20:51:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 22:16:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:16:50]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-10-10 16:34:51]

Description was changed from

==========
ChannelSplitterNode channelCount and mode are fixed.

The channelCount for a ChannelSplitterNode is now set to the number of
outputs and cannot be changed.  The channelCountMode is also fixed to
"explicit".

BUG=653234
TEST=constructor/channelsplitter.html updated
==========

to

==========
ChannelSplitterNode channelCount and mode are fixed.

The channelCount for a ChannelSplitterNode is now set to the number of
outputs and cannot be changed.  The channelCountMode is also fixed to
"explicit".

Feature: https://www.chromestatus.com/feature/4701085050601472

BUG=653234
TEST=constructor/channelsplitter.html updated
==========

[Raymond Toy, 2016-10-10 16:35:20]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-10-10 16:35:22]

PTAL

[hongchan, 2016-10-10 16:44:09]

lgtm

[Raymond Toy, 2016-10-10 17:06:48]

https://codereview.chromium.org/2394953002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.cpp (right):

https://codereview.chromium.org/2394953002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.cpp:90: //
channelCount must be 1.
Wrong!

[Raymond Toy, 2016-10-10 17:13:56]

rtoy@chromium.org changed reviewers:
+ tkent@chromium.org

[Raymond Toy, 2016-10-10 17:13:57]

tkent: PTAL as API Owner. This is a user-visible change, clarifying and
simplifying how ChannelSplitterNode works. Do I need an intent to implement
here?

[tkent, 2016-10-11 14:02:25]

On 2016/10/10 at 17:13:57, rtoy wrote:
> tkent: PTAL as API Owner. This is a user-visible change, clarifying and
simplifying how ChannelSplitterNode works. Do I need an intent to implement
here?

Was the specification unclear?  How non-Blink implementations work?

[Raymond Toy, 2016-10-11 17:32:47]

On 2016/10/11 14:02:25, tkent wrote:
> On 2016/10/10 at 17:13:57, rtoy wrote:
> > tkent: PTAL as API Owner. This is a user-visible change, clarifying and
> simplifying how ChannelSplitterNode works. Do I need an intent to implement
> here?
> 
> Was the specification unclear?  How non-Blink implementations work?

The proposed changes are compatible with the old implementation, if the user
used the defaults.  If the user changed the defaults, some complicated behavior
would happen with down/up mixing the inputs and then down/up mixing that to
create the outputs for the node.  This change in the spec disallows changing the
values so the splitter node keeps doing the obvious thing.

(The spec issue is https://github.com/WebAudio/web-audio-api/issues/975)

hongchan@ just did a http archive search and no site changes the
channelCountMode for a ChannelSplitterNode.

[tkent, 2016-10-11 23:29:18]

On 2016/10/11 at 17:32:47, rtoy wrote:
> On 2016/10/11 14:02:25, tkent wrote:
> > On 2016/10/10 at 17:13:57, rtoy wrote:
> > > tkent: PTAL as API Owner. This is a user-visible change, clarifying and
> > simplifying how ChannelSplitterNode works. Do I need an intent to implement
> > here?
> > 
> > Was the specification unclear?  How non-Blink implementations work?
> 
> The proposed changes are compatible with the old implementation, if the user
used the defaults.  If the user changed the defaults, some complicated behavior
would happen with down/up mixing the inputs and then down/up mixing that to
create the outputs for the node.  This change in the spec disallows changing the
values so the splitter node keeps doing the obvious thing.
> 
> (The spec issue is https://github.com/WebAudio/web-audio-api/issues/975)
> 
> hongchan@ just did a http archive search and no site changes the
channelCountMode for a ChannelSplitterNode.

Thank you for the explanation.  I think nice to have an intent-to-ship.

[Raymond Toy, 2016-10-11 23:31:57]

Sure, I'll do an intent soon.

On Oct 11, 2016 4:29 PM, <tkent@chromium.org> wrote:

> On 2016/10/11 at 17:32:47, rtoy wrote:
> > On 2016/10/11 14:02:25, tkent wrote:
> > > On 2016/10/10 at 17:13:57, rtoy wrote:
> > > > tkent: PTAL as API Owner. This is a user-visible change, clarifying
> and
> > > simplifying how ChannelSplitterNode works. Do I need an intent to
> implement
> > > here?
> > >
> > > Was the specification unclear? How non-Blink implementations work?
> >
> > The proposed changes are compatible with the old implementation, if the
> user
> used the defaults. If the user changed the defaults, some complicated
> behavior
> would happen with down/up mixing the inputs and then down/up mixing that to
> create the outputs for the node. This change in the spec disallows
> changing the
> values so the splitter node keeps doing the obvious thing.
> >
> > (The spec issue is https://github.com/WebAudio/web-audio-api/issues/975)
> >
> > hongchan@ just did a http archive search and no site changes the
> channelCountMode for a ChannelSplitterNode.
>
> Thank you for the explanation. I think nice to have an intent-to-ship.
>
>
> https://codereview.chromium.org/2394953002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Raymond Toy, 2016-10-11 23:31:58]

Sure, I'll do an intent soon.

On Oct 11, 2016 4:29 PM, <tkent@chromium.org> wrote:

> On 2016/10/11 at 17:32:47, rtoy wrote:
> > On 2016/10/11 14:02:25, tkent wrote:
> > > On 2016/10/10 at 17:13:57, rtoy wrote:
> > > > tkent: PTAL as API Owner. This is a user-visible change, clarifying
> and
> > > simplifying how ChannelSplitterNode works. Do I need an intent to
> implement
> > > here?
> > >
> > > Was the specification unclear? How non-Blink implementations work?
> >
> > The proposed changes are compatible with the old implementation, if the
> user
> used the defaults. If the user changed the defaults, some complicated
> behavior
> would happen with down/up mixing the inputs and then down/up mixing that to
> create the outputs for the node. This change in the spec disallows
> changing the
> values so the splitter node keeps doing the obvious thing.
> >
> > (The spec issue is https://github.com/WebAudio/web-audio-api/issues/975)
> >
> > hongchan@ just did a http archive search and no site changes the
> channelCountMode for a ChannelSplitterNode.
>
> Thank you for the explanation. I think nice to have an intent-to-ship.
>
>
> https://codereview.chromium.org/2394953002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Raymond Toy, 2016-10-12 15:47:03]

Description was changed from

==========
ChannelSplitterNode channelCount and mode are fixed.

The channelCount for a ChannelSplitterNode is now set to the number of
outputs and cannot be changed.  The channelCountMode is also fixed to
"explicit".

Feature: https://www.chromestatus.com/feature/4701085050601472

BUG=653234
TEST=constructor/channelsplitter.html updated
==========

to

==========
ChannelSplitterNode channelCount and mode are constant.

The channelCount for a ChannelSplitterNode is now set to the number of
outputs and cannot be changed.  The channelCountMode is also fixed to
"explicit".

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/wavuM3cciPc/1Df3Hrr-...
Feature: https://www.chromestatus.com/feature/4701085050601472

BUG=653234
TEST=constructor/channelsplitter.html updated
==========

[Raymond Toy, 2016-10-17 19:54:49]

Intent has 3 approvals now.

[Raymond Toy, 2016-10-17 19:54:58]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-10-17 19:54:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2394953002/#ps20001
(title: "Rebase and fix incorrect comment")

[commit-bot: I haz the power, 2016-10-17 19:55:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 21:26:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 21:26:47]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Raymond Toy, 2016-10-18 15:49:03]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-10-18 15:49:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 17:47:46]

Description was changed from

==========
ChannelSplitterNode channelCount and mode are constant.

The channelCount for a ChannelSplitterNode is now set to the number of
outputs and cannot be changed.  The channelCountMode is also fixed to
"explicit".

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/wavuM3cciPc/1Df3Hrr-...
Feature: https://www.chromestatus.com/feature/4701085050601472

BUG=653234
TEST=constructor/channelsplitter.html updated
==========

to

==========
ChannelSplitterNode channelCount and mode are constant.

The channelCount for a ChannelSplitterNode is now set to the number of
outputs and cannot be changed.  The channelCountMode is also fixed to
"explicit".

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/wavuM3cciPc/1Df3Hrr-...
Feature: https://www.chromestatus.com/feature/4701085050601472

BUG=653234
TEST=constructor/channelsplitter.html updated
==========

[commit-bot: I haz the power, 2016-10-18 17:47:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-18 18:52:44]

Description was changed from

==========
ChannelSplitterNode channelCount and mode are constant.

The channelCount for a ChannelSplitterNode is now set to the number of
outputs and cannot be changed.  The channelCountMode is also fixed to
"explicit".

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/wavuM3cciPc/1Df3Hrr-...
Feature: https://www.chromestatus.com/feature/4701085050601472

BUG=653234
TEST=constructor/channelsplitter.html updated
==========

to

==========
ChannelSplitterNode channelCount and mode are constant.

The channelCount for a ChannelSplitterNode is now set to the number of
outputs and cannot be changed.  The channelCountMode is also fixed to
"explicit".

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/wavuM3cciPc/1Df3Hrr-...
Feature: https://www.chromestatus.com/feature/4701085050601472

BUG=653234
TEST=constructor/channelsplitter.html updated

Committed: https://crrev.com/efb11f5a890fd4a793dbf8383fb8b529ddf39898
Cr-Commit-Position: refs/heads/master@{#426006}
==========

[commit-bot: I haz the power, 2016-10-18 18:52:45]

Patchset 2 (id:??) landed as
https://crrev.com/efb11f5a890fd4a793dbf8383fb8b529ddf39898
Cr-Commit-Position: refs/heads/master@{#426006}