Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html

Issue 2394953002: ChannelSplitterNode channelCount and mode are constant (Closed)
Patch Set: Rebase and fix incorrect comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html b/third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html
index 79f7982cc45561096003f0a99bf93d38db3e06d9..cba6eddaf0b829b34150db397eae618988421f0e 100644
--- a/third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html
+++ b/third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html
@@ -59,9 +59,9 @@
success = Should("node.numberOfOutputs", node.numberOfOutputs)
.beEqualTo(6) && success;
success = Should("node.channelCount", node.channelCount)
- .beEqualTo(2) && success;
+ .beEqualTo(node.numberOfOutputs) && success;
success = Should("node.channelCountMode", node.channelCountMode)
- .beEqualTo("max") && success;
+ .beEqualTo("explicit") && success;
success = Should("node.channelInterpretation", node.channelInterpretation)
.beEqualTo("speakers") && success;
@@ -74,7 +74,17 @@
});
audit.defineTask("test AudioNodeOptions", function (taskDone) {
- testAudioNodeOptions(context, "ChannelSplitterNode");
+ testAudioNodeOptions(context, "ChannelSplitterNode", {
+ expectedChannelCount: {
+ value: 6,
+ isFixed: true,
+ errorType: "InvalidStateError"
+ },
+ expectedChannelCountMode: {
+ value: "explicit",
+ isFixed: true
+ }
+ });
taskDone();
});
@@ -110,7 +120,7 @@
function () {
node = new ChannelSplitterNode(context, options);
})
- .notThrow() && success;
+ .throw("InvalidStateError") && success;
options = { channelCountMode: "max"};
success = Should("new ChannelSplitterNode(c, " + JSON.stringify(options) + ")",
@@ -119,7 +129,7 @@
channelCountMode: "max"
});
})
- .notThrow() && success;
+ .throw("InvalidStateError") && success;
Should("new ChannelSplitterNode() with options", success)
.summarize(
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698