Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2394913002: In update-w3c-test-expectations, stage all new files before committing. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
jsbell, jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In update-w3c-test-expectations, stage all new files before committing. Currently, w3c-test-autoroller is blocked on importing because new baseline files are not added and committed before uploading. Example of a build where this happens: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7732. Purpose: This CL would unblock this issue on w3c-test-autoroller. This would be unnecessary (and could be reverted) if either of http://crrev.com/2397573002 or http://crrev.com/2396433004 is committed. BUG=621599 Committed: https://crrev.com/6212078b2160aac8c8310d2a484a499d5b8a6c86 Cr-Commit-Position: refs/heads/master@{#423728}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
qyearsley
4 years, 2 months ago (2016-10-05 18:38:39 UTC) #2
jeffcarp
lgtm
4 years, 2 months ago (2016-10-06 17:34:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394913002/1
4 years, 2 months ago (2016-10-06 17:48:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/275534)
4 years, 2 months ago (2016-10-06 18:00:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394913002/20001
4 years, 2 months ago (2016-10-06 20:19:20 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 23:21:30 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 23:24:31 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6212078b2160aac8c8310d2a484a499d5b8a6c86
Cr-Commit-Position: refs/heads/master@{#423728}

Powered by Google App Engine
This is Rietveld 408576698