third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py - Issue 2394913002: In update-w3c-test-expectations, stage all new files before committing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

Issue 2394913002: In update-w3c-test-expectations, stage all new files before committing. (Closed)

Patch Set: Rebased Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

index b6e9fd6f8d877b384ff212647d6d0b2b55cabd38..f59a5b3824cb82e30deef1bcf2ee13d7c8f5d4f9 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

@@ -83,6 +83,9 @@ class RebaselineCL(AbstractParallelRebaselineCommand):

if options.dry_run:

return

+ # NOTE(qyearsley): If this is changed to stage all new files with git,

+ # e.g. if update_scm is not False, then update_w3c_test_expectations.py

+ # should be changed to not call git add --all.

self.rebaseline(options, test_prefix_list, update_scm=False)

def _filter_existing(self, test_prefix_list):

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py » ('j') | no next file with comments »