Enforce comment formatting in platform/

Enforce comment formatting in platform/

Like https://codereview.chromium.org/2394883002/ but for platform.

Also rewrap a few last comments that landed in the last day,
and reformat platform.

BUG=563793
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7e724c7e59e6ee69afe2f54b25448b1745be8f98
Cr-Commit-Position: refs/heads/master@{#423318}

[Nico, 2016-10-05 21:16:29]

Description was changed from

==========
Enforce comment formatting in platform/

Like https://codereview.chromium.org/2394883002/ but for platform.

Also rewrap a few last comments that landed in the last day.

BUG=563793
==========

to

==========
Enforce comment formatting in platform/

Like https://codereview.chromium.org/2394883002/ but for platform.

Also rewrap a few last comments that landed in the last day.

BUG=563793
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Nico, 2016-10-05 21:16:34]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2016-10-05 21:16:44]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org

[commit-bot: I haz the power, 2016-10-05 21:17:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-10-05 21:18:32]

LGTM, but how come there are non-comment related formatting changes (e.g. in the
intrinsics in TransformationMatrix.cpp)?

https://codereview.chromium.org/2394853003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h (right):

https://codereview.chromium.org/2394853003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h:55: 1 << 0, 
// Dump extra debugging info like layer addresses.
I guess this got wrapped during the mega reformat, maybe put this (and the other
comment on its own line?)

[Nico, 2016-10-05 21:21:19]

I reran `time find third_party/WebKit/Source/platform/ -name '*.cpp' -o
-name '*.h' -o -name '*.mm' | xargs buildtools/linux64/clang-format -i` --
I guess the "you must format" presubmit only runs locally and not on the
chromium_presubmit bot? Updated CL description to say that it reformats
everything, not just comments.

On Wed, Oct 5, 2016 at 5:18 PM, <dcheng@chromium.org> wrote:

> LGTM, but how come there are non-comment related formatting changes (e.g.
> in the
> intrinsics in TransformationMatrix.cpp)?
>
>
> https://codereview.chromium.org/2394853003/diff/1/third_
> party/WebKit/Source/platform/graphics/GraphicsLayerClient.h
> File third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h
> (right):
>
> https://codereview.chromium.org/2394853003/diff/1/third_
> party/WebKit/Source/platform/graphics/GraphicsLayerClient.h#newcode55
> third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h:55: 1
> << 0, // Dump extra debugging info like layer addresses.
> I guess this got wrapped during the mega reformat, maybe put this (and
> the other comment on its own line?)
>
> https://codereview.chromium.org/2394853003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2016-10-05 21:21:19]

I reran `time find third_party/WebKit/Source/platform/ -name '*.cpp' -o
-name '*.h' -o -name '*.mm' | xargs buildtools/linux64/clang-format -i` --
I guess the "you must format" presubmit only runs locally and not on the
chromium_presubmit bot? Updated CL description to say that it reformats
everything, not just comments.

On Wed, Oct 5, 2016 at 5:18 PM, <dcheng@chromium.org> wrote:

> LGTM, but how come there are non-comment related formatting changes (e.g.
> in the
> intrinsics in TransformationMatrix.cpp)?
>
>
> https://codereview.chromium.org/2394853003/diff/1/third_
> party/WebKit/Source/platform/graphics/GraphicsLayerClient.h
> File third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h
> (right):
>
> https://codereview.chromium.org/2394853003/diff/1/third_
> party/WebKit/Source/platform/graphics/GraphicsLayerClient.h#newcode55
> third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h:55: 1
> << 0, // Dump extra debugging info like layer addresses.
> I guess this got wrapped during the mega reformat, maybe put this (and
> the other comment on its own line?)
>
> https://codereview.chromium.org/2394853003/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nico, 2016-10-05 21:21:46]

Description was changed from

==========
Enforce comment formatting in platform/

Like https://codereview.chromium.org/2394883002/ but for platform.

Also rewrap a few last comments that landed in the last day.

BUG=563793
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Enforce comment formatting in platform/

Like https://codereview.chromium.org/2394883002/ but for platform.

Also rewrap a few last comments that landed in the last day,
and reformat platform.

BUG=563793
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Nico, 2016-10-05 21:23:01]

Thanks!

https://codereview.chromium.org/2394853003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h (right):

https://codereview.chromium.org/2394853003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h:55: 1 << 0, 
// Dump extra debugging info like layer addresses.
On 2016/10/05 21:18:31, dcheng wrote:
> I guess this got wrapped during the mega reformat, maybe put this (and the
other
> comment on its own line?)

Done.

[Nico, 2016-10-05 21:23:05]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-10-05 21:23:05]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2394853003/#ps20001
(title: "change")

[commit-bot: I haz the power, 2016-10-05 21:24:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 22:37:06]

Description was changed from

==========
Enforce comment formatting in platform/

Like https://codereview.chromium.org/2394883002/ but for platform.

Also rewrap a few last comments that landed in the last day,
and reformat platform.

BUG=563793
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Enforce comment formatting in platform/

Like https://codereview.chromium.org/2394883002/ but for platform.

Also rewrap a few last comments that landed in the last day,
and reformat platform.

BUG=563793
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-10-05 22:37:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 22:41:11]

Description was changed from

==========
Enforce comment formatting in platform/

Like https://codereview.chromium.org/2394883002/ but for platform.

Also rewrap a few last comments that landed in the last day,
and reformat platform.

BUG=563793
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Enforce comment formatting in platform/

Like https://codereview.chromium.org/2394883002/ but for platform.

Also rewrap a few last comments that landed in the last day,
and reformat platform.

BUG=563793
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7e724c7e59e6ee69afe2f54b25448b1745be8f98
Cr-Commit-Position: refs/heads/master@{#423318}
==========

[commit-bot: I haz the power, 2016-10-05 22:41:12]

Patchset 2 (id:??) landed as
https://crrev.com/7e724c7e59e6ee69afe2f54b25448b1745be8f98
Cr-Commit-Position: refs/heads/master@{#423318}